Skip to content

Commit f50fb8f

Browse files
committed
Correct the help output
The uncompressed size, read from the header, is what dictates the decompression/decoding method. Signed-off-by: Matt Lord <mattalord@gmail.com>
1 parent e2490f1 commit f50fb8f

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

go/flags/endtoend/vtcombo.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ Flags:
2121
--backup_storage_compress if set, the backup files will be compressed. (default true)
2222
--backup_storage_number_blocks int if backup_storage_compress is true, backup_storage_number_blocks sets the number of blocks that can be processed, in parallel, before the writer blocks, during compression (default is 2). It should be equal to the number of CPUs available for compression. (default 2)
2323
--bind-address string Bind address for the server. If empty, the server will listen on all available unicast and anycast IP addresses of the local system.
24-
--binlog-in-memory-decompressor-max-size uint This value sets the compressed transaction payload size at which we switch from in-memory buffer based decompression to the slower streaming mode. (default 134217728)
24+
--binlog-in-memory-decompressor-max-size uint This value sets the uncompressed transaction payload size at which we switch from in-memory buffer based decompression to the slower streaming mode. (default 134217728)
2525
--binlog_host string PITR restore parameter: hostname/IP of binlog server.
2626
--binlog_password string PITR restore parameter: password of binlog server.
2727
--binlog_player_protocol string the protocol to download binlogs from a vttablet (default "grpc")

go/flags/endtoend/vttablet.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ Flags:
5656
--backup_storage_implementation string Which backup storage implementation to use for creating and restoring backups.
5757
--backup_storage_number_blocks int if backup_storage_compress is true, backup_storage_number_blocks sets the number of blocks that can be processed, in parallel, before the writer blocks, during compression (default is 2). It should be equal to the number of CPUs available for compression. (default 2)
5858
--bind-address string Bind address for the server. If empty, the server will listen on all available unicast and anycast IP addresses of the local system.
59-
--binlog-in-memory-decompressor-max-size uint This value sets the compressed transaction payload size at which we switch from in-memory buffer based decompression to the slower streaming mode. (default 134217728)
59+
--binlog-in-memory-decompressor-max-size uint This value sets the uncompressed transaction payload size at which we switch from in-memory buffer based decompression to the slower streaming mode. (default 134217728)
6060
--binlog_host string PITR restore parameter: hostname/IP of binlog server.
6161
--binlog_password string PITR restore parameter: password of binlog server.
6262
--binlog_player_grpc_ca string the server ca to use to validate servers when connecting

go/vt/vttablet/common/flags.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,5 +96,5 @@ func registerFlags(fs *pflag.FlagSet) {
9696

9797
fs.IntVar(&vreplicationParallelInsertWorkers, "vreplication-parallel-insert-workers", vreplicationParallelInsertWorkers, "Number of parallel insertion workers to use during copy phase. Set <= 1 to disable parallelism, or > 1 to enable concurrent insertion during copy phase.")
9898

99-
fs.Uint64Var(&mysql.ZstdInMemoryDecompressorMaxSize, "binlog-in-memory-decompressor-max-size", mysql.ZstdInMemoryDecompressorMaxSize, "This value sets the compressed transaction payload size at which we switch from in-memory buffer based decompression to the slower streaming mode.")
99+
fs.Uint64Var(&mysql.ZstdInMemoryDecompressorMaxSize, "binlog-in-memory-decompressor-max-size", mysql.ZstdInMemoryDecompressorMaxSize, "This value sets the uncompressed transaction payload size at which we switch from in-memory buffer based decompression to the slower streaming mode.")
100100
}

0 commit comments

Comments
 (0)