Skip to content

Commit f8ed4d9

Browse files
committed
Add tabletmanager/vdiff to CODEOWNERS and adjust tests
Signed-off-by: Matt Lord <mattalord@gmail.com>
1 parent 39a0ddd commit f8ed4d9

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ go.sum @ajm188 @deepthi @harshit-gangal @mattlord @rohit-nayak-ps @systay @froui
7272
/go/vt/vttablet/tabletmanager/rpc_throttler.go @shlomi-noach @mattlord @timvaillancourt
7373
/go/vt/vttablet/tabletserver/throttle @shlomi-noach @mattlord @timvaillancourt
7474
/go/vt/vttablet/tabletmanager/vreplication @rohit-nayak-ps @mattlord
75+
/go/vt/vttablet/tabletmanager/vdiff @rohit-nayak-ps @mattlord
7576
/go/vt/vttablet/tabletmanager/vstreamer @rohit-nayak-ps @mattlord
7677
/go/vt/vttablet/tabletserver* @harshit-gangal @systay @shlomi-noach @rohit-nayak-ps @timvaillancourt
7778
/go/vt/vttablet/tabletserver/messager @mattlord @rohit-nayak-ps @derekperkins

go/vt/vtctl/workflow/traffic_switcher_test.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -966,7 +966,8 @@ func TestCancelMigration_TABLES(t *testing.T) {
966966
err = topo.CheckKeyspaceLocked(ctx, ts.sourceKeyspace)
967967
require.NoError(t, err)
968968

969-
ts.cancelMigration(ctx, sm)
969+
err = ts.cancelMigration(ctx, sm)
970+
require.NoError(t, err)
970971

971972
// Expect the queries to be cleared
972973
assert.Empty(t, env.tmc.vrQueries[100])
@@ -1027,7 +1028,8 @@ func TestCancelMigration_SHARDS(t *testing.T) {
10271028
err = topo.CheckKeyspaceLocked(ctx, ts.sourceKeyspace)
10281029
require.NoError(t, err)
10291030

1030-
ts.cancelMigration(ctx, sm)
1031+
err = ts.cancelMigration(ctx, sm)
1032+
require.NoError(t, err)
10311033

10321034
// Expect the queries to be cleared
10331035
assert.Empty(t, env.tmc.vrQueries[100])

0 commit comments

Comments
 (0)