Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

episodeName is rarely ever included #3

Closed
platelminto opened this issue Apr 10, 2020 · 2 comments
Closed

episodeName is rarely ever included #3

platelminto opened this issue Apr 10, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@platelminto
Copy link
Owner

platelminto commented Apr 10, 2020

Though the episodeName field is non-guaranteed, and should be obtained through an online provider (e.g. tmdb, omdb, etc.), the parsing for it rarely ever works - it would be nice for it to be somewhat useful.

To avoid a loss in accuracy of other fields, we could implement this as a set of very precise (but common) formats, that could parse items such as:

Australian.Story.S25E07.One.Day.At.A.Time.480p.x264-mSD[TGx]

and

doctor_who_2005.8x12.death_in_heaven.720p_hdtv_x264-fov.

Alternatively, a more generic regex candidate would look for a sentence-like structure (2+ words with normal capitalization, maybe that match none of the other patterns), and that is disconnected (probably defined as having at least another field in between them) from the title. This would likely need to change parse.py, in addition to the normal addition of a new regex pattern.

@platelminto platelminto added enhancement New feature or request good first issue Good for newcomers labels Apr 10, 2020
@platelminto
Copy link
Owner Author

Links to #1, as we might be able to make our episodeName matching more generic if we can exclude movie titles completely (if that's something #1 will end up addressing).

@platelminto platelminto self-assigned this Apr 18, 2020
@platelminto
Copy link
Owner Author

Fixed, matches based on consistent capitalization of episode name and by checking it is located after the episode pattern (as episode names are usually placed there).

Need to add a few more tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant