Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look at system time, together with manual limit, to check max possible release year #39

Open
platelminto opened this issue Nov 24, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@platelminto
Copy link
Owner

platelminto commented Nov 24, 2021

Currently, we need to update valid release years every decade. If we were to just allow any 20XX date, it would be fine if there are multiple years in the torrent name (usually true), but in the below example it wouldn't work:

Blade Runner 2049.HDRip.XviD.AC3-EVO

As it would parse 2049 as the release year. When we do reach the year 2049 though, there is no way to know whether it's a release year or part of the title, so we'd have to add it as a manual exception.

Regardless, maybe we look at system time in combination with a manual check. So, right now we allow 1900-2029 - maybe we allow up to 2029 OR current_system_year, so if we forget to update this library in 2030, it doesn't suddenly break. We also don't just depend on the system year as it might be wrong (super early, maybe), so we still keep the manual year.

@platelminto platelminto changed the title How to handle release years Look at system time, together with manual limit, to check max possible release year Nov 24, 2021
@platelminto platelminto added the good first issue Good for newcomers label Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant