Fix left clicking input to edit #92
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where left-clicking on input elements within graph nodes was not working properly for editing. The solution prevents click events on input elements from propagating to the parent node, which was intercepting these events and triggering node selection instead of allowing input interaction.
Key Changes:
- Added a new private method
_preventNodeSelectionOnInputthat stops event propagation on input elements - Integrated this method into the input creation flow to apply the fix to all node inputs
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
slimbuck
approved these changes
Oct 23, 2025
Member
slimbuck
left a comment
slimbuck
left a comment
There was a problem hiding this comment.
Any idea what caused this to break?
Contributor
Author
|
I have no freaking idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not propagate click events on input elements.
Fixes #91