Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read edits in a locale-independent manner #203

Open
Lysxia opened this issue Sep 11, 2022 · 0 comments
Open

Read edits in a locale-independent manner #203

Lysxia opened this issue Sep 11, 2022 · 0 comments

Comments

@Lysxia
Copy link
Collaborator

Lysxia commented Sep 11, 2022

Issue mentioned on Zulip.

edits are currently read with text's readFile which seems to depend on the locale (like base). And by Murphy's law of locales it is going to be the wrong one for somebody. To make it more robust, we should just require UTF-8, by reading a bytestring and decoding it explicitly. And double check that the edits syntax handles \r for Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant