Migrate old python rules from please repo (#74)

* Copy old rules across

* Add testrunner_bootstrap config key

* Update config variables

* Copy over old pex tool

* Rename new tool to v2

* Remove unused function

* Re-arrange third party deps to minimise changes

* Update tool version

* Get rid of preloads

* Delete v2 rules

* Make bools bools, otherwise flag checks in the build language don't work

* Delete wheel tool and tests referencing deleted zip functions

* Fix testrunner tests

* Update changelog and trigger release from v1 branch

* Update version and changelog in tools directory

Author: samwestmoreland

.github/workflows/plugin.yaml

@@ -24,7 +24,7 @@ jobs:
   release:
     needs: [test]
     runs-on: ubuntu-latest
-    if: github.ref == 'refs/heads/master'
+    if: github.ref == 'refs/heads/master' || github.ref == 'refs/heads/v1'
     steps:
       - name: Checkout code
         uses: actions/checkout@v2

.plzconfig

@@ -1,10 +1,11 @@
 [Please]
-Version = 16.20.0-beta.16
+Version = 16.21.3
 
 [Build]
 hashcheckers = sha256
 
 [Parse]
+PreloadSubincludes = ///go//build_defs:go
 PreloadBuildDefs = test/build_defs/test.build_defs
 
 [Plugin "go"]
@@ -24,7 +25,7 @@ Inherit = true
 
 [PluginConfig "pex_tool"]
 ConfigKey = PexTool
-DefaultValue = //tools:please_pex
+DefaultValue = //tools/please_pex
 Inherit = true
 
 [PluginConfig "interpreter_options"]
@@ -39,6 +40,10 @@ DefaultValue = unittest
 ConfigKey = TestrunnerDeps
 DefaultValue = //third_party/python:unittest_bootstrap
 
+[PluginConfig "test_runner_bootstrap"]
+ConfigKey = TestrunnerBootstrap
+DefaultValue = ""
+
 [PluginConfig "debugger"]
 ConfigKey = Debugger
 DefaultValue = pdb
@@ -62,6 +67,7 @@ Optional = true
 [PluginConfig "use_pypi"]
 ConfigKey = UsePypi
 DefaultValue = true
+Type = bool
 
 [PluginConfig "pip_flags"]
 ConfigKey = PipFlags
@@ -72,6 +78,7 @@ Optional = true
 ConfigKey = DisableVendorFlags
 DefaultValue = false
 Inherit = true
+Type = bool
 
 [PluginConfig "pip_compile_flags"]
 ConfigKey = PipCompileFlags

ChangeLog

@@ -1,3 +1,7 @@
+Version 1.0.0
+-------------
+    * Migrate old rules across from main please repo
+
 Version 0.6.1
 -------------
     * Use remote file for tools #69

VERSION

@@ -1 +1 @@
-0.6.1
+1.0.0

build_defs/python.build_defs

@@ -2,7 +2,6 @@ subinclude("//tools:version", "//build_defs:archs")
 
 release_files = {
     "please_pex": "//tools/please_pex",
-    "wheel_resolver": "//tools/wheel_resolver",
 }
 
 def release_file(name:str, file_target:str, arch:str):

package/BUILD

@@ -1,4 +1,4 @@
 plugin_repo(
     name = "go",
-    revision = "v0.3.0",
-)
+    revision = "v0.4.1",
+)

plugins/BUILD

@@ -1,5 +1,18 @@
 subinclude("//build_defs:python")
 
+package(
+    default_visibility = ["PUBLIC"],
+    python = {
+        "WHEEL_REPO": "https://get.please.build/third_party/python/py3",
+        "WHEEL_NAME_SCHEME": [
+            "{url_base}/{package_name}-{version}-${{OS}}_${{ARCH}}.whl",
+            "{url_base}/{package_name}-{version}.whl",
+            "https://files.pythonhosted.org/packages/py3/{initial}/{package_name}/{package_name}-{version}-py3-none-any.whl",
+            "https://files.pythonhosted.org/packages/py2.py3/{initial}/{package_name}/{package_name}-{version}-py2.py3-none-any.whl",
+        ],
+    },
+)
+
 python_binary(
     name = "strip_source",
     main = "strip_source.py",
@@ -181,21 +194,6 @@ python_test(
     deps = ["//third_party/python:cx_oracle"],
 )
 
-# There's no wheel naming scheme in here so this
-# will use the wheel_resolver tool
-gentest(
-    name = "simple_wheel_resolver_test",
-    srcs = [":cryptography"],
-    no_test_output = True,
-    test_cmd = "true",
-)
-
-python_wheel(
-    name = "cryptography",
-    package_name = "cryptography",
-    version = "35.0.0",
-)
-
 plz_e2e_test(
     name = "correct_labels_on_pip_libary_non_zip_safe",
     cmd = "plz query print -f labels //third_party/python:numpy",
@@ -211,13 +209,3 @@ plz_e2e_test(
     labels = ["py3"],
     deps = ["//third_party/python:grpcio"],
 )
-
-python_test(
-    name = "tensorflow_test",
-    srcs = ["tensorflow_test.py"],
-    labels = [
-        "py3",
-        "pip",
-    ],
-    deps = ["//third_party/python:tensorflow"],
-)

test/BUILD

@@ -3,7 +3,7 @@ subinclude("//build_defs:python")
 package(
     python = {
         "TEST_RUNNER": "test.custom_runner.runner.run",
-        "TESTRUNNER_DEPS": "//test/custom_runner:runner",
+        "TEST_RUNNER_BOOTSTRAP": "//test/custom_runner:runner",
     },
 )
 

test/custom_runner/custom_runner_package/BUILD

@@ -21,6 +21,50 @@ go_module(
     visibility = ["PUBLIC"],
 )
 
+go_module(
+    name = "testify",
+    install = [
+        "assert",
+        "require",
+    ],
+    licences = ["MIT"],
+    module = "github.com/stretchr/testify",
+    version = "v1.7.0",
+    visibility = ["PUBLIC"],
+    deps = [
+        ":difflib",
+        ":spew",
+        ":yaml",
+    ],
+)
+
+go_module(
+    name = "difflib",
+    install = ["difflib"],
+    licences = ["BSD-3-Clause"],
+    module = "github.com/pmezard/go-difflib",
+    version = "v1.0.0",
+    visibility = ["PUBLIC"],
+)
+
+go_module(
+    name = "spew",
+    install = ["spew"],
+    licences = ["ISC"],
+    module = "github.com/davecgh/go-spew",
+    patch = "spew_omit_empty.patch",
+    version = "v1.1.1",
+    visibility = ["PUBLIC"],
+)
+
+go_module(
+    name = "yaml",
+    licences = ["MIT"],
+    module = "gopkg.in/yaml.v3",
+    version = "v3.0.0-20210107192922-496545a6307b",
+    visibility = ["PUBLIC"],
+)
+
 go_module(
     name = "cli-init",
     install = ["..."],