Skip to content

Commit 64ec2a6

Browse files
Run e2e tests using plugin-integration-testing plugin
`test/build_defs/test.build_defs` contains a vendorised, outdated version of the `plz_e2e_test` build definition that has since been migrated to its own plugin, please-build/plugin-integration-testing. Use the build definition provided by the latest version of that plugin rather than the vendorised copy.
1 parent bfc7d40 commit 64ec2a6

File tree

4 files changed

+14
-63
lines changed

4 files changed

+14
-63
lines changed

.plzconfig

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@ Version = >=17.12.2
44
[Build]
55
hashcheckers = sha256
66

7-
[Parse]
8-
PreloadBuildDefs = test/build_defs/test.build_defs
9-
107
[Plugin "go"]
118
Target = //plugins:go
129
ImportPath = github.com/please-build/python-rules
@@ -19,6 +16,9 @@ DisableVendorFlags = true
1916
[Plugin "shell"]
2017
Target = //plugins:shell
2118

19+
[Plugin "e2e"]
20+
Target = //plugins:e2e
21+
2222
[PluginDefinition]
2323
name = python
2424

plugins/BUILD

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,9 @@ plugin_repo(
77
name = "shell",
88
revision = "v0.1.2",
99
)
10+
11+
plugin_repo(
12+
name = "e2e",
13+
plugin = "plugin-integration-testing",
14+
revision = "v1.0.3",
15+
)

test/BUILD

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
1-
subinclude("//build_defs:python", "///shell//build_defs:shell")
1+
subinclude(
2+
"///e2e//build_defs:e2e",
3+
"///shell//build_defs:shell",
4+
"//build_defs:python",
5+
)
26

37
package(
48
default_visibility = ["PUBLIC"],

test/build_defs/test.build_defs

Lines changed: 0 additions & 59 deletions
This file was deleted.

0 commit comments

Comments
 (0)