Exclude in-repo python from pexes (#218)

* add test

* Handle it

* version

Author: peterebden

ChangeLog

@@ -1,3 +1,7 @@
+Version 1.10.1
+--------------
+    * Exclude in-repo interpreters from collection for pexes during remote execution (#218)
+
 Version 1.10.0
 --------------
     * Support in-repo interpreters for tests & add a default shebang (#194)

VERSION

@@ -1 +1 @@
-1.10.0
+1.10.1

build_defs/python.build_defs

@@ -52,6 +52,9 @@ def python_library(name:str, srcs:list=[], resources:list=[], deps:list=[], visi
                 cmd = ' && '.join([compile_cmd, 'rm -f $SRCS_SRCS', cmd])
             else:
                 cmd = ' && '.join([compile_cmd, cmd])
+        if looks_like_build_label(interpreter) and ('|' in interpreter):
+            before, _, _ = interpreter.partition('|')
+            cmd += f' --exclude_tools="$(location {before})"'
         # Pre-zip the files for later collection by python_binary.
         zip_rule = build_rule(
             name=name,

test/BUILD

@@ -180,3 +180,8 @@ python_test(
     name = "ci_test",
     srcs = ["ci_test.py"],
 )
+
+python_test(
+    name = "interpreter_not_included_test",
+    srcs = ["interpreter_not_included_test.py"],
+)

test/interpreter_not_included_test.py

@@ -0,0 +1,18 @@
+import sys
+import unittest
+import zipfile
+
+
+class InterpreterNotIncludedTest(unittest.TestCase):
+
+    def test_interpreter_is_not_included(self):
+        """Test that we don't include the interpreter as a tool."""
+        zf = zipfile.ZipFile(sys.argv[0])
+        names = [name for name in zf.namelist() if "third_party/cpython/lib" in name]
+        self.assertFalse(names)
+
+    def test_arcat_is_not_included(self):
+        """Test that arcat isn't included either."""
+        zf = zipfile.ZipFile(sys.argv[0])
+        names = [name for name in zf.namelist() if "arcat" in name]
+        self.assertFalse(names)