From 7980e5d261f390d62581a47f8fda4a56e1c95224 Mon Sep 17 00:00:00 2001 From: Chris Novakovic Date: Wed, 29 Oct 2025 11:00:47 +0000 Subject: [PATCH] Remove cx-Oracle import test `//test:cx_oracle_darwin_build_test` just ensures that cx-Oracle is importable and defines a `__version__` attribute. The test name implies that the build process for cx-Oracle itself - specifically on Darwin - is what matters in this test, although it's not clear why: the test predates Please's plugin architecture, and was inherited from the main Please repo. cx-Oracle has been abandoned since 2022 [1] and hasn't had a new version published on PyPI since 2021 [2]. The final version only has pre-built wheels available for Python <= 3.10 manylinux SOABIs, so pip has to build it from source for the vast majority of SOABIs. It's not clear why this is a price worth paying any more, so remove it (and the test that depends on it). [1] https://oracle.github.io/python-cx_Oracle/ [2] https://pypi.org/project/cx-Oracle/8.3.0/ --- test/BUILD | 9 --------- test/cx_oracle_darwin_build_test.py | 11 ----------- third_party/python/BUILD | 7 ------- 3 files changed, 27 deletions(-) delete mode 100644 test/cx_oracle_darwin_build_test.py diff --git a/test/BUILD b/test/BUILD index 108ddae5..56de60d2 100644 --- a/test/BUILD +++ b/test/BUILD @@ -137,15 +137,6 @@ python_test( data = {"txt": ["data.txt"]}, ) -python_test( - name = "cx_oracle_darwin_build_test", - srcs = ["cx_oracle_darwin_build_test.py"], - labels = [ - "pip", - ], - deps = ["//third_party/python:cx_oracle"], -) - plugin_e2e_test( name = "pip_libary_zip_safe_label_test", repo = "zip_safe_label_repo", diff --git a/test/cx_oracle_darwin_build_test.py b/test/cx_oracle_darwin_build_test.py deleted file mode 100644 index 0b81eb7d..00000000 --- a/test/cx_oracle_darwin_build_test.py +++ /dev/null @@ -1,11 +0,0 @@ -import time -import unittest - - -class CxOracleTest(unittest.TestCase): - - def test_import(self): - start = time.time() - import cx_Oracle - end = time.time() - print('Imported cx_Oracle version %s in %0.2fs' % (cx_Oracle.__version__, end - start)) diff --git a/third_party/python/BUILD b/third_party/python/BUILD index 6513b4e6..8c54fea7 100644 --- a/third_party/python/BUILD +++ b/third_party/python/BUILD @@ -383,13 +383,6 @@ pip_library( version = "1.5", ) -pip_library( - name = "cx_oracle", - package_name = "cx-Oracle", - licences = ["BSD-3-Clause"], - version = "8.2.1", -) - pip_library( name = "distlib", licences = ["PSF-2.0"],