diff --git a/choreographer/browser.py b/choreographer/browser.py index 2bb27be5..c21b2f95 100644 --- a/choreographer/browser.py +++ b/choreographer/browser.py @@ -82,7 +82,8 @@ def __init__( and not isinstance(stderr, int) ): try: stderr.fileno() except io.UnsupportedOperation: - warnings.warn("A value has been passed to debug_browser which is not compatible with python. The default value if deug_browser is True is whatever the value of sys.stderr is. sys.stderr may be many things but debug_browser must be a value Popen accepts for stderr, or True.") + warnings.warn("A value has been passed to debug_browser which is not compatible with python's Popen. This may be because one was passed to Browser or because sys.stderr has been overrided by a framework. Browser logs will not be handled by python in this case.") + stderr = None diff --git a/tests/conftest.py b/tests/conftest.py index b274b0f0..c61769be 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -46,7 +46,7 @@ def pytest_addoption(parser): async def browser(request): headless = request.config.getoption("--headless") debug = request.config.get_verbosity() > 2 - debug_browser = None if debug else False # what's going on here + debug_browser = None if debug else False browser = await choreo.Browser( headless=headless, debug=debug, debug_browser=debug_browser )