Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMPORTANT: API Design Improvement: V1: add a browser.Open() awaitable to make API more explicit #103

Open
ayjayt opened this issue Oct 1, 2024 · 3 comments
Open

IMPORTANT: API Design Improvement: V1: add a browser.Open() awaitable to make API more explicit #103

ayjayt opened this issue Oct 1, 2024 · 3 comments
Assignees
@ayjayt

Comments

@ayjayt
Copy link
Collaborator

ayjayt commented Oct 1, 2024 •
edited
Loading

to resolve issues such as : #100

(i make that mistake too so I think it needs to be more clear from API how to use)
@ayjayt
Copy link
Collaborator Author

ayjayt commented Oct 1, 2024

it can probably just wrap await()? or vice verse is better

@ayjayt
Copy link
Collaborator Author

ayjayt commented Oct 2, 2024 •
edited
Loading

There will be a:

browser = Browser()
await browser.open()

browser = Browser_sync()
browser.open()

@gvwilson

@ayjayt ayjayt changed the title add a browser.Open() awaitable to make API more explicit IMPORTANT: API Design Improvement: V1: add a browser.Open() awaitable to make API more explicit Oct 2, 2024
@ayjayt ayjayt self-assigned this Oct 2, 2024
@gvwilson
Copy link
Contributor

gvwilson commented Oct 3, 2024

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ayjayt ayjayt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gvwilson @ayjayt