Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add posiedon option to v1 #118

Open
Divide-By-0 opened this issue Nov 29, 2024 · 1 comment
Open

Add posiedon option to v1 #118

Divide-By-0 opened this issue Nov 29, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Divide-By-0
Copy link
Member

Divide-By-0 commented Nov 29, 2024

Protocols like Mina and Aztec have replaced Sha with Poseidon for the time being, as it is faster to optimize in their respective zk proving languages. We should standardize this option, as well as expose consistent and correct JavaScript libraries for it, as well as include an amendment to the EIP. I'm open to renaming V1 and V2 till like V1-Poseidon or something like that, or releasing V3 for Poseidon where the proving always happens on the user/client side because you can include all the hashing there.

They also be worth noting that v1v2v3 may not be the best ways to define the standard, because we're not incrementing the version such that later versions are better, they just all encapsulate different trade-offs.

It would be ideal to standardize the mina version so nothing has to change!

@Divide-By-0 Divide-By-0 changed the title Add posiedon option to both v1 and v2 Add posiedon option to v1 Nov 29, 2024
@Divide-By-0 Divide-By-0 added the enhancement New feature or request label Nov 29, 2024
@skaunov skaunov self-assigned this Dec 15, 2024
@skaunov
Copy link
Collaborator

skaunov commented Dec 15, 2024

So, my plan is the following. Along the way I will be adding abstraction/generality, though as much as possible while avoiding getting tumbled in weeds.

  1. describe Mina implementation
  2. add and reference Mina Nullifier RFC
  3. look into the Noir lib pull request if there's anything to add to the result of previous steps
  4. start to add this to the reference implementation here
  5. in parallel review the patch to the ERC and commit the contribution
  6. finish the reference implementation accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants