Binary::readBool(): fixed incorrect results returned when passing a string longer than 1

dktapps · dktapps · commit 55c24fc78af6 · 2021-12-31T22:02:15.000Z
diff --git a/src/Binary.php b/src/Binary.php
@@ -104,7 +104,7 @@ private static function safeUnpack(string $formatCode, string $bytes, int $needL
 	 * Reads a byte boolean
 	 */
 	public static function readBool(string $b) : bool{
-		return $b !== "\x00";
+		return $b[0] !== "\x00";
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ private static function safeUnpack(string $formatCode, string $bytes, int $needL`
`104`	`104`	`* Reads a byte boolean`
`105`	`105`	`*/`
`106`	`106`	`public static function readBool(string $b) : bool{`
`107`		`- return $b !== "\x00";`
	`107`	`+ return $b[0] !== "\x00";`
`108`	`108`	`}`
`109`	`109`
`110`	`110`	`/**`