From e8b116955b92f9aae5085b12171da5717e82f76d Mon Sep 17 00:00:00 2001 From: Kris Date: Mon, 20 Nov 2023 16:53:02 -0800 Subject: [PATCH 1/2] [fix] OrbitControls calcs wrong lookAt with matrixAutoUpdate false --- src/controls/OrbitControls.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/controls/OrbitControls.ts b/src/controls/OrbitControls.ts index a4d73372..9454da53 100644 --- a/src/controls/OrbitControls.ts +++ b/src/controls/OrbitControls.ts @@ -289,6 +289,7 @@ class OrbitControls extends EventDispatcher { position.copy(scope.target).add(offset) + if (!scope.object.matrixAutoUpdate) scope.object.updateMatrix(); scope.object.lookAt(scope.target) if (scope.enableDamping === true) { From 555a46730072e0864fd54823b95992b26d426421 Mon Sep 17 00:00:00 2001 From: Cody Bennett Date: Tue, 21 Nov 2023 19:45:36 -0600 Subject: [PATCH 2/2] chore: lint --- src/controls/OrbitControls.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/controls/OrbitControls.ts b/src/controls/OrbitControls.ts index 9454da53..ca964f69 100644 --- a/src/controls/OrbitControls.ts +++ b/src/controls/OrbitControls.ts @@ -289,7 +289,7 @@ class OrbitControls extends EventDispatcher { position.copy(scope.target).add(offset) - if (!scope.object.matrixAutoUpdate) scope.object.updateMatrix(); + if (!scope.object.matrixAutoUpdate) scope.object.updateMatrix() scope.object.lookAt(scope.target) if (scope.enableDamping === true) {