From 5a5804d51a7de7c0c7cd94bac11a3a85fdbc19e0 Mon Sep 17 00:00:00 2001
From: Cody Bennett <hi@codyb.co>
Date: Thu, 12 Sep 2024 16:16:01 -0500
Subject: [PATCH 1/2] feat(EffectComposer): add dispose

---
 src/postprocessing/EffectComposer.ts | 9 ++++++++-
 src/postprocessing/ShaderPass.ts     | 5 +++++
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/src/postprocessing/EffectComposer.ts b/src/postprocessing/EffectComposer.ts
index 42c21ea0..b8acaad4 100644
--- a/src/postprocessing/EffectComposer.ts
+++ b/src/postprocessing/EffectComposer.ts
@@ -15,7 +15,7 @@ class EffectComposer<TRenderTarget extends WebGLRenderTarget = WebGLRenderTarget
   public readBuffer: WebGLRenderTarget
   public renderToScreen: boolean
   public passes: Pass[] = []
-  public copyPass: Pass
+  public copyPass: ShaderPass
   public clock: Clock
 
   constructor(renderer: WebGLRenderer, renderTarget?: TRenderTarget) {
@@ -195,6 +195,13 @@ class EffectComposer<TRenderTarget extends WebGLRenderTarget = WebGLRenderTarget
 
     this.setSize(this._width, this._height)
   }
+
+  public dispose() {
+    this.renderTarget1.dispose()
+    this.renderTarget2.dispose()
+
+    this.copyPass.dispose()
+  }
 }
 
 export { EffectComposer }
diff --git a/src/postprocessing/ShaderPass.ts b/src/postprocessing/ShaderPass.ts
index 48ab0588..f1bc6ed6 100644
--- a/src/postprocessing/ShaderPass.ts
+++ b/src/postprocessing/ShaderPass.ts
@@ -52,6 +52,11 @@ class ShaderPass extends Pass {
       this.fsQuad.render(renderer)
     }
   }
+
+  public dispose() {
+    this.fsQuad.dispose()
+    this.material.dispose()
+  }
 }
 
 export { ShaderPass }

From a31788cda2c1ea1c1d99f2f85054a403036106d5 Mon Sep 17 00:00:00 2001
From: Cody Bennett <hi@codyb.co>
Date: Thu, 12 Sep 2024 16:18:03 -0500
Subject: [PATCH 2/2] chore: lint

---
 src/postprocessing/EffectComposer.ts | 2 +-
 src/postprocessing/Pass.ts           | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/postprocessing/EffectComposer.ts b/src/postprocessing/EffectComposer.ts
index b8acaad4..30927665 100644
--- a/src/postprocessing/EffectComposer.ts
+++ b/src/postprocessing/EffectComposer.ts
@@ -15,7 +15,7 @@ class EffectComposer<TRenderTarget extends WebGLRenderTarget = WebGLRenderTarget
   public readBuffer: WebGLRenderTarget
   public renderToScreen: boolean
   public passes: Pass[] = []
-  public copyPass: ShaderPass
+  public copyPass: Pass
   public clock: Clock
 
   constructor(renderer: WebGLRenderer, renderTarget?: TRenderTarget) {
diff --git a/src/postprocessing/Pass.ts b/src/postprocessing/Pass.ts
index 83c756b9..c69f0c9b 100644
--- a/src/postprocessing/Pass.ts
+++ b/src/postprocessing/Pass.ts
@@ -24,6 +24,8 @@ class Pass {
   ): void {
     console.error('THREE.Pass: .render() must be implemented in derived pass.')
   }
+
+  public dispose() {}
 }
 
 // Helper for passes that need to fill the viewport with a single quad.