[BUG] Get-PnPRecycleBinItem does not return all items

[gaiking-uk]

Issue description

• The Get-PnPRecycleBinItem documentation specifically states that if Get-PnPRecycleBinItem is called without passing either -FirstStage or -SecondStage, the cmdlet will return "All" items in the recycle bin.
• This is not correct however, in fact the -FirstStage is implied even when not passed explicitly and the only way to get a list of all items in the recycle bin is to run the cmdlet twice (once with -FirstStage and again with -SecondStage) and then merge the result sets together.
• In essence, Get-PnPRecycleBinItem -FirstStage and Get-PnPRecycleBinItem are identical.

Scenario:

• There are 3,000 items in the recycle bin overall
• There are 1,000 items in the first stage recycle bin
• There are 2,000 items in the second stage recycle bin

Expected behavior

• Running Get-PnPRecycleBinItem -FirstStage returns the 1,000 items in the first stage recycle bin
• Running Get-PnPRecycleBinItem -SecondStage returns the 2,000 items in the second stage recycle bin
• Running Get-PnPRecycleBinItem returns all 3,000 items in the recycle bin, across both the first and second stages

Actual behavior

• Running Get-PnPRecycleBinItem -FirstStage returns the 1,000 items in the first stage recycle bin
• Running Get-PnPRecycleBinItem -SecondStage returns the 2,000 items in the second stage recycle bin
• Running Get-PnPRecycleBinItem also returns the 1,000 items in the first stage recycle bin (only) and does return any items that are in the second stage recycle bin

Steps to reproduce behaviour

• Replicate the above scenario and tests

What is the version of the Cmdlet module you are running?

• 3.1.0

Which operating system/environment are you running PnP PowerShell on?

• Windows
• Linux
• MacOS
• Azure Cloud Shell
• Azure Functions
• Other : please specify

[reshmee011]

@gaiking-uk The underlying API doesn’t support returning deleted items from both recycle bin stages when neither FirstStage nor SecondStage is specified. The documentation also doesn’t indicate that items from both stages would be returned by default. We may want to update the docs to make it clear by default firststage deleted items would be returned.

[gaiking-uk]

Thanks for your message @reshmee011

The underlying API doesn’t support returning deleted items from both recycle bin stages

If it's not possible for the cmdlet to get items from the first and second stage in a single call, that's fine, this issue was primarily about raising that the documentation is not correct.

The documentation also doesn’t indicate that items from both stages would be returned by default

Respectfully, the documentation states this explicitly...

Similarly, to get items from the first stage only, the documentation currently states that you need to supply the -FirstStage parameter.

We may want to update the docs to make it clear by default firststage deleted items would be returned.

Sure, I am happy to submit a PR to update the page if you wish?

[reshmee011]

@gaiking-uk : Thanks for spotting the inaccuracies in the documentation. I hadn’t reviewed those examples closely enough, so I really appreciate you calling them out. Please do go ahead and submit a PR to update the page, we’re always happy to welcome new contributors!

[gaiking-uk]

No problem @reshmee011, am happy to help!

I've drafted a proposed update to the documentation which should clarify this going forward and submitted this as PR #5266 -- I'll go close this ticked once the PR is approved.

Thanks for your help and quick replies on this! 👍🏼