Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support non-standard tarball urls in JFrog Artifactory #16

Open
banyudu opened this issue Dec 22, 2022 · 0 comments
Open

Comments

@banyudu
Copy link

banyudu commented Dec 22, 2022

In JFrog Artifactory based npm registry, tarball urls are not always:

${registry}${pkgName}/-/${scopelessName}-${removeBuildMetadataFromVersion(pkgVersion)}.tgz

There are two different cases for scoped packages:

  1. Synced npm packages, such as @pnpm/exe@7.18.2, resolves to http://myhost/artifactory/api/npm/npm-virtual/@pnpm/exe/-/exe-7.18.2.tgz
  2. Self Managed packages, say @mycompany/sth@1.0.0, resolves to http://myhost/artifactory/api/npm/npm-virtual/@mycompany/sth/-/@mycompany/sth-1.0.0.tgz, which uses full name instead of scopeless name.

This issue makes a lot confusion when we trying to migrate to pnpm, and the best solution so far is enable lockfile-include-tarball-url.

Could there be an option to use full name instead of scopeless name for given scopes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant