{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":651366050,"defaultBranch":"master","name":"bitcoin","ownerLogin":"pochingchen","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-06-09T04:54:18.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/122552609?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1688346501.525412","currentOid":""},"activityList":{"items":[{"before":"538363738e9e30813cf3e76ca4f71c1aaff349e7","after":"ff100bb549f21dc0136af9241fd2de6daffb19a2","ref":"refs/heads/master","pushedAt":"2024-07-15T06:25:09.000Z","pushType":"push","commitsCount":218,"pusher":{"login":"pochingchen","name":"陈伯卿","path":"/pochingchen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/122552609?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui#825: Show maximum mempool size in information window\n\n4a028cf54c0502bc9ba0804bf1ae413b20a007cb gui: show maximum mempool size in information window (Sebastian Falbesoner)\nbbde6ffefea9587b07a9f8d4043b2dd23ef8c3c5 add node interface method for getting maximum mempool size (Sebastian Falbesoner)\n\nPull request description:\n\n This PR adds the maximum mempool size to the information window (Menu \"Window\" -> \"Information\" -> section \"Memory Pool\" -> line \"Memory usage\").\n\n master:\n\n \n\n PR:\n\n \n\nACKs for top commit:\n MarnixCroes:\n tested ACK 4a028cf54c0502bc9ba0804bf1ae413b20a007cb\n pablomartin4btc:\n tACK 4a028cf54c0502bc9ba0804bf1ae413b20a007cb\n luke-jr:\n tACK 4a028cf54c0502bc9ba0804bf1ae413b20a007cb & in Knots\n hebasto:\n ACK 4a028cf54c0502bc9ba0804bf1ae413b20a007cb, tested on Ubuntu 24.04.\n\nTree-SHA512: c10fb23605d060cea19a86d11822fc4d12496b19547870052aace503670e62e4c4e19ae4c2c4fbf7420a472adb071c9ddebe82447e0cfbce5a6fb9fcd7b9eda3","shortMessageHtmlLink":"Merge bitcoin-core/gui#825: Show maximum mempool size in information …"}},{"before":"70e4d6ff1d269abbda9dafae659e3da3ea17867a","after":"538363738e9e30813cf3e76ca4f71c1aaff349e7","ref":"refs/heads/master","pushedAt":"2024-06-24T10:05:26.000Z","pushType":"push","commitsCount":498,"pusher":{"login":"pochingchen","name":"陈伯卿","path":"/pochingchen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/122552609?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30314: doc: clarify Cirrus self-hosted workers setup\n\nc67f215ea5fd57cd05e5346b8cd292dd879303ff ci: clarify Cirrus self-hosted workers setup (Sjors Provoost)\n\nPull request description:\n\n Taken from #29274 (except for two paragraphs that require the other commits in that PR).\n\nACKs for top commit:\n maflcko:\n ACK c67f215ea5fd57cd05e5346b8cd292dd879303ff\n tdb3:\n ACK c67f215ea5fd57cd05e5346b8cd292dd879303ff\n\nTree-SHA512: 321cc327bfbf0b8e55eb84cb259cf55a66d480c99abe6824248f8b5fdb9a31a079f7ce2c5a6c27afa809aa343d1efb0744a19dd379c17162b21fdf24b6b8836b","shortMessageHtmlLink":"Merge bitcoin#30314: doc: clarify Cirrus self-hosted workers setup"}},{"before":"256e1703197fdddd78bc6d659431cd0fc3b63cde","after":"70e4d6ff1d269abbda9dafae659e3da3ea17867a","ref":"refs/heads/master","pushedAt":"2024-05-03T16:17:40.000Z","pushType":"push","commitsCount":168,"pusher":{"login":"pochingchen","name":"陈伯卿","path":"/pochingchen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/122552609?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30026: refactor, test: Always initialize pointer\n\nbd2de7ac591d7704b79304089ad1fb57e085da8b refactor, test: Always initialize pointer (Hennadii Stepanov)\n\nPull request description:\n\n This change fixes MSVC warning [C4703](https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4703).\n\n All `DisableSpecificWarnings` dropped from `test_bitcoin.vcxproj` as all remained are inherited from `common.init.vcxproj`.\n\n Required to simplify warning suppression porting to the CMake-based build system.\n\nACKs for top commit:\n maflcko:\n utACK bd2de7ac591d7704b79304089ad1fb57e085da8b\n sipsorcery:\n utACK bd2de7ac591d7704b79304089ad1fb57e085da8b.\n ryanofsky:\n Code review ACK bd2de7ac591d7704b79304089ad1fb57e085da8b\n\nTree-SHA512: 006db041d3c3697a77d9df14de86cf7c8a10804b45789df01268b2236cf6452e77dc57e89f5d5a6bc26d4b5cd483f0722d6035649c8a523b57954bb1fc810d0c","shortMessageHtmlLink":"Merge bitcoin#30026: refactor, test: Always initialize pointer"}},{"before":"c7567d9223a927a88173ff04eeb4f54a5c02b43d","after":"256e1703197fdddd78bc6d659431cd0fc3b63cde","ref":"refs/heads/master","pushedAt":"2024-04-23T06:28:21.000Z","pushType":"push","commitsCount":45,"pusher":{"login":"pochingchen","name":"陈伯卿","path":"/pochingchen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/122552609?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29777: test: refactor: introduce and use `calculate_input_weight` helper\n\n6d91cb781c30966963f28e7577c7aa3829fa9390 test: add unit tests for `calculate_input_weight` (Sebastian Falbesoner)\nf81fad5e0f3be1f7aed59f9da00396c75c2a6406 test: introduce and use `calculate_input_weight` helper (Sebastian Falbesoner)\n\nPull request description:\n\n Rather than manually estimating an input's weight by adding up all the involved components (fixed-size skeleton, compact-serialized lengths, and the actual scriptSig / witness stack items) we can simply take use of the serialization classes `CTxIn` / `CTxInWitness` instead, to achieve the same with significantly less code.\n\n The new helper is used in the functional tests rpc_psbt.py and wallet_send.py, where the previous manual estimation code was\n duplicated. Unit tests are added in the second commit.\n\nACKs for top commit:\n kevkevinpal:\n tACK [6d91cb7](https://github.com/bitcoin/bitcoin/pull/29777/commits/6d91cb781c30966963f28e7577c7aa3829fa9390)\n QureshiFaisal:\n tACK [6d91cb7](https://github.com/bitcoin/bitcoin/pull/29777/commits/6d91cb781c30966963f28e7577c7aa3829fa9390)\n achow101:\n ACK 6d91cb781c30966963f28e7577c7aa3829fa9390\n AngusP:\n tACK 6d91cb781c30966963f28e7577c7aa3829fa9390\n rkrux:\n tACK [6d91cb7](https://github.com/bitcoin/bitcoin/pull/29777/commits/6d91cb781c30966963f28e7577c7aa3829fa9390)\n\nTree-SHA512: 04424e4d94d0e13745a9c11df2dd3697c98552bbb0e792c4af67ecbb66060adc3cc0cefc202cdee2d9db0baf85b8bedf2eb339ac4b316d986b5f10f6b70c5a33","shortMessageHtmlLink":"Merge bitcoin#29777: test: refactor: introduce and use `calculate_inp…"}},{"before":"8f1185feec3efdb8d0e3f6b7d0aee67bbdc3d653","after":"c7567d9223a927a88173ff04eeb4f54a5c02b43d","ref":"refs/heads/master","pushedAt":"2024-04-16T11:10:34.000Z","pushType":"push","commitsCount":67,"pusher":{"login":"pochingchen","name":"陈伯卿","path":"/pochingchen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/122552609?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29886: doc: archive 27.0 release notes\n\nc08754971d207bd2b60ba9c4faf34396a97bbc26 doc: archive 27.0 release notes (fanquake)\n\nPull request description:\n\nACKs for top commit:\n laanwj:\n ACK c08754971d207bd2b60ba9c4faf34396a97bbc26\n stickies-v:\n ACK c08754971d207bd2b60ba9c4faf34396a97bbc26\n\nTree-SHA512: ee910a35f0e74e02e8297ed655766995fbf5dc03ce3a9efd90986c22fea3693dedd0d2941fbcc94007cd77548985ac1c1d202644e822d1408f72faccb1472d80","shortMessageHtmlLink":"Merge bitcoin#29886: doc: archive 27.0 release notes"}},{"before":"0d509bab45d292caeaf34600e57b5928757c6005","after":"8f1185feec3efdb8d0e3f6b7d0aee67bbdc3d653","ref":"refs/heads/master","pushedAt":"2024-04-06T08:22:14.000Z","pushType":"push","commitsCount":19,"pusher":{"login":"pochingchen","name":"陈伯卿","path":"/pochingchen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/122552609?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29805: test: Fix debug recommendation in argsman_tests\n\n561a650e0f669159699224ddd4eb5b1c91cf9ac3 test: Fix debug recommendation in argsman_tests (Fabian Jahr)\n\nPull request description:\n\n There are recommendations in the `argsman_tests` comments on how to re-run and debug a test failure to see if it reflects an expected or unexpected change. The command tries to run a test in `util_tests` but this is in `argsman_tests` so the command doesn't work with just copy+paste. I didn't investigate further but I suspect that these tests were moved between files.\n\nACKs for top commit:\n fanquake:\n ACK 561a650e0f669159699224ddd4eb5b1c91cf9ac3\n\nTree-SHA512: b3bb94ba1635c9455149b455f2b30ee37a8067a6242339531ab54d428177a288da29a4a10702652305eb34aa7638f51dad35fa6b0e7b74617e445327b8c4c053","shortMessageHtmlLink":"Merge bitcoin#29805: test: Fix debug recommendation in argsman_tests"}},{"before":"c1223188e0a5fb11c3a1b9224511a49dc2f848ed","after":"0d509bab45d292caeaf34600e57b5928757c6005","ref":"refs/heads/master","pushedAt":"2024-04-04T08:34:02.000Z","pushType":"push","commitsCount":120,"pusher":{"login":"pochingchen","name":"陈伯卿","path":"/pochingchen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/122552609?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29527: depends: add -g to DEBUG=1 flags\n\n84fbf9b2841a9ba1ebd1421b9ff9fe444bb1abd9 depends: remove -g from sqlite debug flags (fanquake)\neef51afc6a29c693a68400930ef8011be41b7401 depends: add -g to DEBUG=1 flags (fanquake)\n\nPull request description:\n\n Add `-g` to the base DEBUG=1 flags in depends.\n Avoids the need to specify it per-package.\n More alignment with `--enable-debug` behaviour in configure.\n\n We also want to align the optimization flags, currently -O1 vs -O0, however that can be it's own PR.\n\nACKs for top commit:\n theuni:\n ACK 84fbf9b2841a9ba1ebd1421b9ff9fe444bb1abd9\n\nTree-SHA512: 1ee98ba0c13e4b80bb87632658b4f53ce49c73e0e7712990c30da60deca4a349a744232f2d78f243dee9a07f5b9b70f9c2c4ae34082c34ae51b37b054fac61fd","shortMessageHtmlLink":"Merge bitcoin#29527: depends: add -g to DEBUG=1 flags"}},{"before":"592e01398e765bf3c3f4fc106f40c8be373b4bb0","after":"c1223188e0a5fb11c3a1b9224511a49dc2f848ed","ref":"refs/heads/master","pushedAt":"2024-03-25T02:21:36.000Z","pushType":"push","commitsCount":436,"pusher":{"login":"pochingchen","name":"陈伯卿","path":"/pochingchen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/122552609?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29672: validation: Make translations of fatal errors consistent\n\n824f47294a309ba8e58ba8d1da0af15d8d828f43 node: Use log levels in noui_ThreadSafeMessageBox (TheCharlatan)\nddc7872c08b7ddf9b1e83abdb97c21303f4a9172 node: Make translations of fatal errors consistent (TheCharlatan)\n\nPull request description:\n\n The extra `bilingual_str` argument of the fatal error notifications and `node::AbortNode()` is often unused and when used usually contains the same string as the message argument. It also seems to be confusing, since it is not consistently used for errors requiring user action. For example some assumeutxo fatal errors require the user to do something, but are not translated.\n\n So simplify the fatal error and abort node interfaces by only passing a translated string. This slightly changes the fatal errors displayed to the user.\n\nACKs for top commit:\n stickies-v:\n re-ACK 824f47294a309ba8e58ba8d1da0af15d8d828f43\n maflcko:\n ACK 824f47294a309ba8e58ba8d1da0af15d8d828f43 🔎\n achow101:\n ACK 824f47294a309ba8e58ba8d1da0af15d8d828f43\n hebasto:\n re-ACK 824f47294a309ba8e58ba8d1da0af15d8d828f43.\n\nTree-SHA512: 2868ee7b045fe7f3ac582ce5039141b398480b7627734976201dafaaef7544b8461635a7292fee4a7f32ff1bfc26f9bd4d0c292dca424ba42fb7fc4483d7ce8d","shortMessageHtmlLink":"Merge bitcoin#29672: validation: Make translations of fatal errors co…"}},{"before":"a11585692e72cac468fb1496ea2c30e4c07f73e5","after":"592e01398e765bf3c3f4fc106f40c8be373b4bb0","ref":"refs/heads/master","pushedAt":"2024-02-06T22:54:41.000Z","pushType":"push","commitsCount":14,"pusher":{"login":"pochingchen","name":"陈伯卿","path":"/pochingchen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/122552609?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#28833: wallet: refactor: remove unused `SignatureData` instances in spkm's `FillPSBT` methods\n\ne2ad343f69af4f924b22dccf94a52b6431ef6e3c wallet: remove unused `SignatureData` instances in spkm's `FillPSBT` methods (Sebastian Falbesoner)\n\nPull request description:\n\n These are filled with signature data from a PSBT input, but not used anywhere after, hence they can be removed. Note that the same code is in the `SignPSBTInput` function where the `sigdata` result is indeed used.\n\nACKs for top commit:\n achow101:\n ACK e2ad343f69af4f924b22dccf94a52b6431ef6e3c\n brunoerg:\n crACK e2ad343f69af4f924b22dccf94a52b6431ef6e3c\n\nTree-SHA512: f0cabcc000bcea6bc7d7ec9d3be2e2a8accbdbffbe35252250ea2305b65a5813fde2b8096fbdd2c7cccdf417ea285183dc325fc2d210d88bce62978ce642930e","shortMessageHtmlLink":"Merge bitcoin#28833: wallet: refactor: remove unused SignatureData …"}},{"before":"5b8c5970bdfc817cac9b59f699925c4426c59b61","after":"a11585692e72cac468fb1496ea2c30e4c07f73e5","ref":"refs/heads/master","pushedAt":"2024-02-03T03:00:53.000Z","pushType":"push","commitsCount":11,"pusher":{"login":"pochingchen","name":"陈伯卿","path":"/pochingchen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/122552609?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#28868: wallet: Fix migration of wallets with txs that have both spendable and watchonly outputs\n\n4da76ca24725eb9ba8122317e04a6e1ee14ac846 test: Test migration of tx with both spendable and watchonly (Ava Chow)\nc62a8d03a862fb124b4f4b88efd61978e46605f8 wallet: Keep txs that belong to both watchonly and migrated wallets (Ava Chow)\n71cb28ea8cb579ac04cefc47a57557c94080d1af test: Make sure that migration test does not rescan on reloading (Ava Chow)\n78ba0e6748d2a519a96c41dea851e7c43b82f251 wallet: Reload the wallet if migration exited early (Ava Chow)\n9332c7edda79a39bb729b71b6f8db6a9d37343bb wallet: Write bestblock to watchonly and solvable wallets (Ava Chow)\n\nPull request description:\n\n A transaction does not necessarily have to belong to either the migrated wallet (with the private keys) and the watchonly wallet (with watchonly things), it could have multiple outputs with each isminetype. So we should be putting such transactions in one or the other wallet, but rather putting it in both.\n\n I've added a test for this behavior, however the test also revealed a few other issues. Notably, it revealed that `migratewallet` would have the watchonly wallet rescan from genesis when it is reloaded at the end of migration. This could be a cause for migration appearing to be very slow. This is resolved by first writing best block records to the watchonly and solvable wallets, as well as updating the test to make sure that rescans don't happen.\n\n The change to avoid rescans also found an issue where some of our early exits would result in unloading the wallet even though nothing happened. So there is also a commit to reload the wallet for such early exits.\n\nACKs for top commit:\n ryanofsky:\n Code review ACK 4da76ca24725eb9ba8122317e04a6e1ee14ac846. This looks great. The code is actually cleaner than before, two bugs are fixed, and the test checking for rescanning is pretty clever and broadens test coverage.\n furszy:\n Code review ACK 4da76ca2\n\nTree-SHA512: 5fc210cff16ca6720d7b2d0616d7e3f295c974147854abc704cf99a3bfaad17572ada084859e7a1b1ca94da647ad130303219678f429b7995f85e040236db35c","shortMessageHtmlLink":"Merge bitcoin#28868: wallet: Fix migration of wallets with txs that h…"}},{"before":"4b1196a9855dcd188a24f393aa2fa21e2d61f061","after":"5b8c5970bdfc817cac9b59f699925c4426c59b61","ref":"refs/heads/master","pushedAt":"2024-02-02T03:24:18.000Z","pushType":"push","commitsCount":266,"pusher":{"login":"pochingchen","name":"陈伯卿","path":"/pochingchen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/122552609?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29189: RFC: Deprecate libconsensus\n\n25dc87e6f84c38c21e109e11f7bbd93f1e1f3183 libconsensus: deprecate (Cory Fields)\n\nPull request description:\n\n This library has existed for nearly 10 years with very little known uptake or impact. It has become a maintenance burden. In several cases it dictates our code/library structure (for example necessitating LIBBITCOIN_CRYPTO_BASE), as well as build-system procedures (building multiple copies of object files especially for the lib).\n\n Several discussions have arisen wrt migrating it to CMake and it has become difficult to justify adding more complexity for a library that is virtually unused anyway.\n\n See for example the discussions:\n https://github.com/hebasto/bitcoin/pull/41\n https://github.com/bitcoin/bitcoin/pull/29123\n\n And here: https://github.com/bitcoin/bitcoin/pull/29180\n Where it is pointed out that the libbitcoinconsensus functions are slower than those the internal bitcoind equivalents due to the missing sha2 implementations.\n\n Instead, we (fanquake, hebasto, TheCharlatan, and I) propose simply not migrating it to CMake and letting it end with v27. Any remaining use-cases could be handled in the future by libbitcoinkernel.\n\n If there are any users currently using libbitcoinconsensus, please chime in with your use-case!\n\n Edit: Corrected final release to be v27.\n\nACKs for top commit:\n TheCharlatan:\n ACK 25dc87e6f84c38c21e109e11f7bbd93f1e1f3183\n fanquake:\n ACK 25dc87e6f84c38c21e109e11f7bbd93f1e1f3183 - this library has very little, if any impactful real world usage. It has been entirely broken (on various platforms) for long periods of its existence, where nobody even noticed. Pruning this out to save porting, and starting anew with the kernel, is the sane thing to do.\n\nTree-SHA512: baff2b3c4f76f520c96021035f751fdcb51bedf00e767660249e92a7bc7c5c176786bcf2c4cfe2d2351c200f932b39eb886bcfb22fbec824a41617590d6a1638","shortMessageHtmlLink":"Merge bitcoin#29189: RFC: Deprecate libconsensus"}},{"before":"3695ecbf680a66b718f97d504308578d001eec49","after":"4b1196a9855dcd188a24f393aa2fa21e2d61f061","ref":"refs/heads/master","pushedAt":"2024-01-02T06:06:11.000Z","pushType":"push","commitsCount":28,"pusher":{"login":"pochingchen","name":"陈伯卿","path":"/pochingchen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/122552609?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#28880: build: switch to using LLVM 17.x for macOS builds\n\nb335710782c2545e6eeed67b5e1763c07eab26b0 depends: patch around non-determinism in qt (fanquake)\ne8ecec45756d7121edfaa1321c597d88ce7ec6db build: rename native_clang to native_llvm (fanquake)\nb0c290340c1e1398dc9eb51b3e48a040de3f47d6 Revert \"build: Patch Qt to handle minimum macOS version properly\" (fanquake)\n558250dec15e43b66c7b5a96543dd184925b6209 guix: use clang-toolchain-17 for macOS build (fanquake)\n5ddd7c65b415629d4b57fb238d5fd39b049ccf79 build: Bump `native_clang` up to 17.0.6 (Hennadii Stepanov)\n\nPull request description:\n\n This is the last step before #21778. We need LLVM 17.x so that lld has `-fixup_chains`.\n\nACKs for top commit:\n theuni:\n ACK b335710782c2545e6eeed67b5e1763c07eab26b0.\n TheCharlatan:\n ACK b335710782c2545e6eeed67b5e1763c07eab26b0\n\nTree-SHA512: 8142956196a481178f360258c2e4d924178d552966b713323f29f2deba7e5ec73a3da1c9d79d97c9e7f6aa18ed7429cd6660826aa633e6dde1ac56000b9ad57f","shortMessageHtmlLink":"Merge bitcoin#28880: build: switch to using LLVM 17.x for macOS builds"}},{"before":"ba5f16e4a1b2b1b187174b44883edb6d7378927b","after":"3695ecbf680a66b718f97d504308578d001eec49","ref":"refs/heads/master","pushedAt":"2023-12-18T05:44:38.000Z","pushType":"push","commitsCount":89,"pusher":{"login":"pochingchen","name":"陈伯卿","path":"/pochingchen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/122552609?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29088: tests: Don't depend on value of DEFAULT_PERMIT_BAREMULTISIG\n\n7b45744df33c6a4759eae1a3984f389cbac837c2 tests: ensure functional tests set permitbaremultisig=1 when needed (Anthony Towns)\n7dfabdcf860c529772a54b0e8fa235cbb4a78b4d tests: test both settings for permitbaremultisig in p2sh tests (Anthony Towns)\n\nPull request description:\n\n Update unit and functional tests so that they continue to work if the default for `-permitbaremultisig` is changed.\n\nACKs for top commit:\n maflcko:\n lgtm ACK 7b45744df33c6a4759eae1a3984f389cbac837c2\n instagibbs:\n crACK https://github.com/bitcoin/bitcoin/pull/29088/commits/7b45744df33c6a4759eae1a3984f389cbac837c2\n ajtowns:\n > crACK [7b45744](https://github.com/bitcoin/bitcoin/commit/7b45744df33c6a4759eae1a3984f389cbac837c2)\n achow101:\n ACK 7b45744df33c6a4759eae1a3984f389cbac837c2\n glozow:\n ACK 7b45744df33c6a4759eae1a3984f389cbac837c2, changed default locally and all tests passed\n\nTree-SHA512: f89f9e2bb11f07662cfd57390196df9e531064e1bd662e1db7dcfc97694394ae5e8014e9d209b9405aa09195bf46fc331b7fba10378065cdb270cbd0669ae904","shortMessageHtmlLink":"Merge bitcoin#29088: tests: Don't depend on value of DEFAULT_PERMIT_B…"}},{"before":"498994b6f55d04a7940f832e7fbd17e5acdaff15","after":"ba5f16e4a1b2b1b187174b44883edb6d7378927b","ref":"refs/heads/master","pushedAt":"2023-12-11T12:32:51.000Z","pushType":"push","commitsCount":83,"pusher":{"login":"pochingchen","name":"陈伯卿","path":"/pochingchen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/122552609?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29044: msvc: Define the same `QT_...` macros as in Autotools builds\n\n1a5dae630df1eef9eac51557b2f1c5dba0924953 msvc: Define the same `QT_...` macros as in Autotools builds (Hennadii Stepanov)\n\nPull request description:\n\n There are no reasons to have such a diversion.\n\n Also it fixes https://github.com/bitcoin/bitcoin/pull/28960#issuecomment-1847971114.\n\nACKs for top commit:\n sipsorcery:\n tACK 1a5dae630df1eef9eac51557b2f1c5dba0924953.\n TheCharlatan:\n ACK 1a5dae630df1eef9eac51557b2f1c5dba0924953\n\nTree-SHA512: 75be5eabb8fec974b8d77a023c72323015a3d95fbc13b7fd85e5f25c250ae67850ddf0bcaef143828d75fe35a49e7c9b1966976b74f3ce7d14465174e6585ceb","shortMessageHtmlLink":"Merge bitcoin#29044: msvc: Define the same QT_... macros as in Auto…"}},{"before":"d752349029ec7a76f1fd440db2ec2e458d0f3c99","after":"498994b6f55d04a7940f832e7fbd17e5acdaff15","ref":"refs/heads/master","pushedAt":"2023-12-01T04:20:54.000Z","pushType":"push","commitsCount":116,"pusher":{"login":"pochingchen","name":"陈伯卿","path":"/pochingchen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/122552609?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#26762: bugfix: Make `CCheckQueue` RAII-styled (attempt 2)\n\n5b3ea5fa2e7f6dc1c9161ed8b74c9be4bd1e92dd refactor: Move `{MAX,DEFAULT}_SCRIPTCHECK_THREADS` constants (Hennadii Stepanov)\n6e17b3168072ab77ed7170ab81327c017877133a refactor: Make `CCheckQueue` non-copyable and non-movable explicitly (Hennadii Stepanov)\n8111e74653dc5c93cb510672d99048c3f741d8dc refactor: Drop unneeded declaration (Hennadii Stepanov)\n9cf89f7a5b81197e38f58b24be0793b28fe41477 refactor: Make `CCheckQueue` constructor start worker threads (Hennadii Stepanov)\nd03eaacbcfb276fb638db1b423113ff43bd7ec41 Make `CCheckQueue` destructor stop worker threads (Hennadii Stepanov)\nbe4ff3060b7b43b496dfb5a2c02b114b2b717106 Move global `scriptcheckqueue` into `ChainstateManager` class (Hennadii Stepanov)\n\nPull request description:\n\n This PR:\n - makes `CCheckQueue` RAII-styled\n - gets rid of the global `scriptcheckqueue`\n - fixes https://github.com/bitcoin/bitcoin/issues/25448\n\n The previous attempt was in https://github.com/bitcoin/bitcoin/pull/18731.\n\nACKs for top commit:\n martinus:\n ACK 5b3ea5fa2e7\n achow101:\n ACK 5b3ea5fa2e7f6dc1c9161ed8b74c9be4bd1e92dd\n TheCharlatan:\n ACK 5b3ea5fa2e7f6dc1c9161ed8b74c9be4bd1e92dd\n\nTree-SHA512: 45cca846e7ed107e3930149f0b616ddbaf2648d6cde381f815331b861b5d67ab39e154883ae174b8abb1dae485bc904318c50c51e5d6b46923d89de51c5eadb0","shortMessageHtmlLink":"Merge bitcoin#26762: bugfix: Make CCheckQueue RAII-styled (attempt 2)"}},{"before":"4458ae811a264968c2a7ea4bb7050eed492a7e36","after":"d752349029ec7a76f1fd440db2ec2e458d0f3c99","ref":"refs/heads/master","pushedAt":"2023-11-19T03:04:42.000Z","pushType":"push","commitsCount":240,"pusher":{"login":"pochingchen","name":"陈伯卿","path":"/pochingchen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/122552609?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#28900: doc: remove mingw-w64 install for \"older\" systems\n\n656a7e9de626ea76f377c7e1e3370a869d7bcca9 doc: remove mingw-w64 install for \"older\" systems (fanquake)\n\nPull request description:\n\n Now that we require GCC 10.1+, the posix variant is available on supported systems.\n\n i.e:\n https://packages.debian.org/bullseye/g++-mingw-w64-x86-64-posix\n https://packages.ubuntu.com/jammy/g++-mingw-w64-x86-64-posix\n\nACKs for top commit:\n maflcko:\n ACK 656a7e9de626ea76f377c7e1e3370a869d7bcca9\n BrandonOdiwuor:\n ACK 656a7e9de626ea76f377c7e1e3370a869d7bcca9\n hebasto:\n ACK 656a7e9de626ea76f377c7e1e3370a869d7bcca9.\n\nTree-SHA512: b7d3696ad5d0322c107ced5750d20c40167caaf7d063cf01da5fc12c4086827f4f73185aa5cc9ac170778b0523c0c16cca3b2419b11019da9d30b936ee897e14","shortMessageHtmlLink":"Merge bitcoin#28900: doc: remove mingw-w64 install for \"older\" systems"}},{"before":"04265ba9378efbd4c35b33390b1e5cf246d420a9","after":"4458ae811a264968c2a7ea4bb7050eed492a7e36","ref":"refs/heads/master","pushedAt":"2023-10-31T08:44:52.000Z","pushType":"push","commitsCount":202,"pusher":{"login":"pochingchen","name":"陈伯卿","path":"/pochingchen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/122552609?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#28741: refactor: Fix bugprone-string-constructor warning\n\nfa56067a8f56701cbda95595592e74934af7d1cd refactor: Fix bugprone-string-constructor warning (MarcoFalke)\n\nPull request description:\n\n String literals in C++ have a trailing null character, so the current code is fine to rely on that implicitly. However,\n * the sqlite documentation explicitly mentions the null character\n * code readers may wonder if the code is intentional\n * clang-tidy warns about the code via `bugprone-string-constructor`\n\n Address the points by putting the null character into the code and enable the clang-tidy `bugprone-string-constructor` check.\n\nACKs for top commit:\n stickies-v:\n ACK fa56067a8f56701cbda95595592e74934af7d1cd\n\nTree-SHA512: da519184d792a885a8151ffc44c8da5781f5aaae12ef768a187cc6d9e542ca8952aebc2ec6c1a05f673f29a86ef44902ee96e7b491af7b4705ad38e14624882e","shortMessageHtmlLink":"Merge bitcoin#28741: refactor: Fix bugprone-string-constructor warning"}},{"before":"61d59fed74108f31eb4e9a2faa3f36422a37000e","after":"04265ba9378efbd4c35b33390b1e5cf246d420a9","ref":"refs/heads/master","pushedAt":"2023-10-10T04:02:04.000Z","pushType":"push","commitsCount":1013,"pusher":{"login":"pochingchen","name":"陈伯卿","path":"/pochingchen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/122552609?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#26331: Implement `CCoinsViewErrorCatcher::HaveCoin` and check disk space periodically\n\ned52e71176fc97c6ed01e3eebd85acdec54b4448 Periodically check disk space to avoid corruption (Aurèle Oulès)\n7fe537f7a48675b1d25542bee6f390d665547580 Implement CCoinsViewErrorCatcher::HaveCoin (Aurèle Oulès)\n\nPull request description:\n\n Attempt to fix #26112.\n\n As suggested by sipa in https://github.com/bitcoin/bitcoin/issues/26112#issuecomment-1249683401:\n > CCoinsViewErrorCatcher, the wrapper class used around CCoinsViewDB that's supposed to detect these problems and forcefully exit the application, has an override for GetCoins. But in CheckTxInputs, HaveInputs is first invoked, which on its turn calls HaveCoin. HaveCoin is implemented in CCoinsViewDB, but not in CCoinsViewErrorCatcher, and thus the disk read exception escapes.\n > A solution may be to just add an override for HaveCoin in CCoinsViewErrorCatcher.\n\n I implemented `CCoinsViewErrorCatcher::HaveCoin` and also added a periodic disk space check that shutdowns the node if there is not enough space left on disk, the minimum here is 50MB.\n\n For reviewers, it's possible to saturate disk space to test the PR by creating large files with `fallocate -l 50G test.bin`\n\nACKs for top commit:\n achow101:\n ACK ed52e71176fc97c6ed01e3eebd85acdec54b4448\n w0xlt:\n Code Review ACK https://github.com/bitcoin/bitcoin/pull/26331/commits/ed52e71176fc97c6ed01e3eebd85acdec54b4448\n sipa:\n utACK ed52e71176fc97c6ed01e3eebd85acdec54b4448\n\nTree-SHA512: 456aa7b996023df42b4fbb5158ee429d9abf7374b7b1ec129b21aea1188ad19be8da4ae8e0edd90b85b7a3042b8e44e17d3742e33808a4234d5ddbe9bcef1b78","shortMessageHtmlLink":"Merge bitcoin#26331: Implement CCoinsViewErrorCatcher::HaveCoin and…"}},{"before":"a36134fcc7b40671d538931f621c8c15ffacc3d2","after":"61d59fed74108f31eb4e9a2faa3f36422a37000e","ref":"refs/heads/master","pushedAt":"2023-07-03T01:08:35.499Z","pushType":"push","commitsCount":240,"pusher":{"login":"pochingchen","name":"陈伯卿","path":"/pochingchen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/122552609?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#24005: test: add python implementation of Elligator swift\n\n4f4d039a98370a91e3cd5977352a9a4b260aa06b test: add ellswift test vectors from BIP324 (stratospher)\na31287718aebad847b232eff59adc16c166c99e8 test: Add ellswift unit tests (stratospher)\n714fb2c02ab4bfdd8a5a4f420036ece217c8b474 test: Add python ellswift implementation to test framework (stratospher)\n\nPull request description:\n\n Built on top of https://github.com/bitcoin/bitcoin/pull/26222.\n\n This PR introduces Elligator swift encoding and decoding in the functional test framework. It's used in #24748 for writing p2p encryption tests.\n\nACKs for top commit:\n sipa:\n ACK 4f4d039a98370a91e3cd5977352a9a4b260aa06b\n theStack:\n ACK 4f4d039a98370a91e3cd5977352a9a4b260aa06b :crocodile:\n\nTree-SHA512: 32bc8e88f715f2cd67dc04cd38db92680872072cb3775478e2c30da89aa2da2742992779ea14da2f1faca09228942cfbd86d6957402b24bf560244b389e03540","shortMessageHtmlLink":"Merge bitcoin#24005: test: add python implementation of Elligator swift"}},{"before":"a36134fcc7b40671d538931f621c8c15ffacc3d2","after":"61d59fed74108f31eb4e9a2faa3f36422a37000e","ref":"refs/heads/master","pushedAt":"2023-07-03T01:08:35.000Z","pushType":"push","commitsCount":240,"pusher":{"login":"pochingchen","name":"陈伯卿","path":"/pochingchen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/122552609?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#24005: test: add python implementation of Elligator swift\n\n4f4d039a98370a91e3cd5977352a9a4b260aa06b test: add ellswift test vectors from BIP324 (stratospher)\na31287718aebad847b232eff59adc16c166c99e8 test: Add ellswift unit tests (stratospher)\n714fb2c02ab4bfdd8a5a4f420036ece217c8b474 test: Add python ellswift implementation to test framework (stratospher)\n\nPull request description:\n\n Built on top of https://github.com/bitcoin/bitcoin/pull/26222.\n\n This PR introduces Elligator swift encoding and decoding in the functional test framework. It's used in #24748 for writing p2p encryption tests.\n\nACKs for top commit:\n sipa:\n ACK 4f4d039a98370a91e3cd5977352a9a4b260aa06b\n theStack:\n ACK 4f4d039a98370a91e3cd5977352a9a4b260aa06b :crocodile:\n\nTree-SHA512: 32bc8e88f715f2cd67dc04cd38db92680872072cb3775478e2c30da89aa2da2742992779ea14da2f1faca09228942cfbd86d6957402b24bf560244b389e03540","shortMessageHtmlLink":"Merge bitcoin#24005: test: add python implementation of Elligator swift"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNy0xNVQwNjoyNTowOS4wMDAwMDBazwAAAAR_Xmdr","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNy0xNVQwNjoyNTowOS4wMDAwMDBazwAAAAR_Xmdr","endCursor":"Y3Vyc29yOnYyOpK7MjAyMy0wNy0wM1QwMTowODozNS4wMDAwMDBazwAAAANNT8C1"}},"title":"Activity · pochingchen/bitcoin"}