Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling] make localnet_shell doesn't work out of the box #814

Closed
3 tasks
Olshansk opened this issue Jun 8, 2023 · 0 comments · Fixed by #806
Closed
3 tasks

[Tooling] make localnet_shell doesn't work out of the box #814

Olshansk opened this issue Jun 8, 2023 · 0 comments · Fixed by #806
Assignees
Labels
tooling tooling to support development, testing et al

Comments

@Olshansk
Copy link
Member

Olshansk commented Jun 8, 2023

Objective

Make make localnet_shell work out of the box

Origin Document

User Experience

The user should be able to use p1 Query Height out of the box without specifying the remoteCLIURL

Screenshot 2023-06-08 at 2 26 09 PM

Code

In the Tilftfile, we have copy the local binary

Screenshot 2023-06-08 at 2 23 02 PM

Even though we try to set RPC_HOST in the configs:

Screenshot 2023-06-08 at 2 23 19 PM

Which is used for configuring the RPC endpoint:

Screenshot 2023-06-08 at 2 25 23 PM

Goals

  • Improve the developer experience

Deliverable

  • Developer should not have to specify remoteCLIURL
  • Until state sync is implemented, it should point to a validator instead of a full node

Testing Methodology

  • p1 Query Height should work right after running make localnet_shell

Creator: @Olshansk

@Olshansk Olshansk added the tooling tooling to support development, testing et al label Jun 8, 2023
@Olshansk Olshansk moved this to In Review in V1 Dashboard Jun 8, 2023
@okdas okdas mentioned this issue Jun 8, 2023
20 tasks
@bryanchriswhite bryanchriswhite linked a pull request Jun 12, 2023 that will close this issue
20 tasks
@github-project-automation github-project-automation bot moved this from In Review to Done in V1 Dashboard Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling tooling to support development, testing et al
Projects
Status: Done
3 participants