Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XCM]: Improved fee mechanism #105

Merged

Conversation

franciscoaguirre
Copy link
Contributor

Moved from polkadot-fellows/xcm-format#53.

The idea is to extend the current XCM fee mechanism to support in principle delivery fees, but potentially other types of fees as well.
This is accomplished by having two additions:

  • PayFees instruction
  • A fees register, where fees go and stay there until the end of execution. Crucially, separate from the holding register

text/0105-xcm-improved-fee-mechanism.md Outdated Show resolved Hide resolved
text/0105-xcm-improved-fee-mechanism.md Outdated Show resolved Hide resolved
text/0105-xcm-improved-fee-mechanism.md Outdated Show resolved Hide resolved
text/0105-xcm-improved-fee-mechanism.md Show resolved Hide resolved
franciscoaguirre and others added 4 commits July 30, 2024 17:08
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
@franciscoaguirre
Copy link
Contributor Author

/rfc propose

@paritytech-rfc-bot
Copy link
Contributor

Hey @franciscoaguirre, here is a link you can use to create the referendum aiming to approve this RFC number 0105.

Instructions
  1. Open the link.

  2. Switch to the Submission tab.

  1. Adjust the transaction if needed (for example, the proposal Origin).

  2. Submit the Transaction


It is based on commit hash dbda71ff556635b523656c8e8af42686d5515372.

The proposed remark text is: RFC_APPROVE(0105,3a2279090ec273a091e02cea25323279745f22391f35b24462279188dfc07734).

Copy link

Voting for this referenda is ongoing.

Vote for it here

Copy link

github-actions bot commented Sep 3, 2024

PR can be merged.

Write the following command to trigger the bot

/rfc process 0x39efd93063aeaef13afdb2135a775fec4d87fe3ed51e9bf122bc73a336acd509

@acatangiu
Copy link
Contributor

/rfc process 0x39efd93063aeaef13afdb2135a775fec4d87fe3ed51e9bf122bc73a336acd509

@paritytech-rfc-bot paritytech-rfc-bot bot merged commit db260ea into polkadot-fellows:main Sep 3, 2024
@paritytech-rfc-bot
Copy link
Contributor

The on-chain referendum has approved the RFC.

@anaelleltd anaelleltd added the Approved Has passed on-chain voting. label Sep 10, 2024
acatangiu added a commit to paritytech/polkadot-sdk that referenced this pull request Oct 17, 2024
Implements [RFC#105](polkadot-fellows/RFCs#105)
which, at the time of this PR, has not been approved yet. Some aspects
might be changed as a result of discussion.

## TODO
- [x] Add new instruction and use it in conversion functions
- [x] Implement in xcm-executor
- [x] Setup for xcm-executor unit tests
- [x] Actual xcm-executor unit tests
  - [x] Happy path
  - [x] Unhappy path
- [x] Emulated tests
  - [x] Asset hub westend
  - [x] Asset hub rococo
- [x] Benchmarks
  - [x] Dummy values
  - [x] Actual benchmarks
- [x] PRDoc

---------

Co-authored-by: command-bot <>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Has passed on-chain voting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants