Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: cannot display 20-byte accounts in polkadot.js #10995

Closed
2 of 4 tasks
ozgunozerk opened this issue Oct 10, 2024 · 9 comments
Closed
2 of 4 tasks

Error: cannot display 20-byte accounts in polkadot.js #10995

ozgunozerk opened this issue Oct 10, 2024 · 9 comments
Assignees
Labels
Bug Tracks issues causing errors or unintended behavior, critical to fix for reliability.

Comments

@ozgunozerk
Copy link

This is a bug report (may be originating from polkadot.js or maybe originating from our runtime).

As OpenZeppelin, we are building an evm template, and using 20-bytes account due the compatibility reasons with ethereum ecosystem.

  • Bug report
  • Feature request
  • Support request
  • Other

What is the current behavior and expected behavior?

As of now, when we try to test our template by deploying a parachain using zombienet, we get the following error in polkadot.js

image -> this is from chrome.

Note that, balance transfers, smart contract deployment, etc. everything works. So we are confident that our template is working in terms of functionality. It is also working with metamask and web3js.

Request and expected behavior

Expected behavior is to not get the above error and being able to display the accounts correctly.

We simply want to know whether this is issue is due to our template, or is it something related to polkadot.js.

As far as we know, Moonbeam also uses 20-byte account types, yet polkadot.js is correctly displaying accounts for them.

Note: for more context, take a look at the relevant PR: OpenZeppelin/polkadot-runtime-templates#326

@IkerAlus
Copy link

Seems similar to #10954

@TarikGul
Copy link
Member

Some more info would be nice, what tab is this in, and is there a way for us to reproduce it?

@piggydoughnut
Copy link
Contributor

piggydoughnut commented Oct 11, 2024

Hey @ozgunozerk 👋🏽 If you are talking about Identities not being displayed correctly due to that parsing error, then I think this should be resolved soon, once we update the api version in the apps :)

Issues solving the Identity problem are:
apps - #10969
api - polkadot-js/api#5991

Reproduction steps would definitely be great 🙌🏽

@ozgunozerk
Copy link
Author

Hi @piggydoughnut and @TarikGul , thanks for the info. Here is the requested detailed steps to reproduce:

following this guide:
https://docs.openzeppelin.com/substrate-runtimes/2.0.1/guides/testing_with_zombienet

on this branch: https://github.com/OpenZeppelin/polkadot-runtime-templates/pull/326/files

Basically, we changed our chain-spec to use evm compatible accounts, and after that change, we started to get this error.

@piggydoughnut, which specific release/update should we keep an eye on for this fix?

@piggydoughnut piggydoughnut self-assigned this Oct 14, 2024
@piggydoughnut piggydoughnut added the Bug Tracks issues causing errors or unintended behavior, critical to fix for reliability. label Oct 14, 2024
@piggydoughnut
Copy link
Contributor

piggydoughnut commented Oct 14, 2024

@ozgunozerk If all goes according to the plan you should be all set this week :) I will ping you once we are done.

You are interested in the next apps release :)

@asiniscalchi
Copy link
Contributor

asiniscalchi commented Oct 15, 2024

Parsing of H160 addresses seems fixed, however problems with wallets arised: #10954 (comment)

@piggydoughnut
Copy link
Contributor

piggydoughnut commented Oct 16, 2024

@ozgunozerk , I am closing this as it should be resolved by now. Please feel free to re-open in case the issue still arises.
In case you experience the same issue as linked in the comment above, check the discussion in the #10954 for the fix suggestion.

@ozgunozerk
Copy link
Author

Seems like it is resolved, thanks!
image

@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Tracks issues causing errors or unintended behavior, critical to fix for reliability.
Projects
None yet
Development

No branches or pull requests

6 participants