Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Lat, Long, and Province/State #9

Open
rlindskog opened this issue Mar 17, 2020 · 12 comments
Open

Support for Lat, Long, and Province/State #9

rlindskog opened this issue Mar 17, 2020 · 12 comments

Comments

@rlindskog
Copy link
Contributor

Hey, great project! It's nice having a cached JSON representation of CSSEGISandData/COVID on github!

What do you think about adding lat / long attributes? Also province/states (maybe in a separate JSON file)?

I can help if it is something you're interested in.

@pomber
Copy link
Owner

pomber commented Mar 17, 2020

Yes! do you want to send a PR changing the action to also create/update a timeline-by-region.json or something similar?

There's also countries.json with some info about each country, feel free to add more info to it.

@titaniumbones
Copy link

I added provincial breakdown here: https://github.com/titaniumbones/covid19 . I don't understand github actions, therefore can't test them, and wanted to get this up ASAP so I just copied actions.js to manual.js and made a few changes there. extracted some logic into named functions. More than happy to make a PR but I won't be able to test till I have a chance to learn about actions (maybe tonight but maybe not.

@titaniumbones
Copy link

(I also added the CSSE repo as a submodule, which makes it easy to update w/ a shell script.)

@pomber
Copy link
Owner

pomber commented Mar 18, 2020

Awesome @titaniumbones.

I'm not sure if you can test the action locally (I don't have too much experience with actions either)

But you could change action.js and test it in your repo in every pull by changing

on:
schedule:
- cron: "15 5,13,21 * * *"

to

on: [push]

If it works, send de PR and I'll merge it.

titaniumbones added a commit to titaniumbones/covid19 that referenced this issue Mar 18, 2020
See pomber#9

Added files with name `provinces-${country}.json` which give
province/state breakdowns.
titaniumbones added a commit to titaniumbones/covid19 that referenced this issue Mar 18, 2020
- add new function `buildSeries` to extract main parsing logic
- create new files `province-${country}.json` for the relevant
countries

Addresses half of pomber#9
@titaniumbones
Copy link

I think I was able to do this in #13 :-/ -- anyway, actions seem to work. on my repo. Also possible to test by running GITHUB_WORKSPACE=somedir after adding the relevant files into somedir/data and somedir/main

@jparish3
Copy link

great work...have provinces been added yet?

@Not-Jayden
Copy link

Any updates on this? Working on a tracker that I'd really love to be able to support state/provinces as well.

@pomber
Copy link
Owner

pomber commented Mar 23, 2020

There are some new changes coming to the source repo (#37).
I would need to change how the data is fetched so I'll add provinces then (in a different json).

@bakman2
Copy link

bakman2 commented Mar 23, 2020

would be nice if the countries could be mapped to their ISO 2 or 3 code, which in turn can be mapped to lon/lat. There are several nodejs libs available that have all the information required.
(and perhaps even a proper ISO date format and deaths today property)

@izaius
Copy link

izaius commented Mar 25, 2020

Would really like state/province level info. Thank you for your work on this so far!

@energee
Copy link
Contributor

energee commented Mar 30, 2020

Long story short, the JHU data is a complete mess, particularly in the daily series, there are key issues in multiple places.

I was working on a pull request for this repo, but required too many hacks to make the API data consistent.

Anyway, I made an API for US state data available here: https://github.com/energee/covid19-us-api based on NY time's csv. Hopefully its helpful!

@jsanjay63
Copy link

Taking the idea from this project, I made available COVID-19 data in GeoJSON format.
Repo URL: https://github.com/jsanjay63/covid19-geoextractor

Sample Data available: https://jsanjay63.github.io/covid19-geoextractor/output/covid19_time_series.geojson

Map Visualization: https://studio.here.com/viewer/?project_id=fc72e094-6ade-4c2f-8e9c-ecf902b36709

Feel free to give feedback or contribute. A small contribution to fight COVID :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants