From 4adc1b709a6a971340b71d7efe1e1132cc9b7cec Mon Sep 17 00:00:00 2001 From: Juhan Bae Date: Thu, 11 Jul 2024 18:54:30 -0400 Subject: [PATCH] backward amp_scale --- kronfluence/arguments.py | 4 ++++ tests/test_analyzer.py | 1 + 2 files changed, 5 insertions(+) diff --git a/kronfluence/arguments.py b/kronfluence/arguments.py index 79cde0e..a5ae0c3 100644 --- a/kronfluence/arguments.py +++ b/kronfluence/arguments.py @@ -151,6 +151,10 @@ def __post_init__(self) -> None: ): raise ValueError("All data and module partitions must be positive.") + # For backward compatibility: + if not hasattr(self, "amp_scale"): + self.amp_scale = 2.0**16 + @dataclass class ScoreArguments(Arguments): diff --git a/tests/test_analyzer.py b/tests/test_analyzer.py index 885b6c9..89b4e77 100644 --- a/tests/test_analyzer.py +++ b/tests/test_analyzer.py @@ -104,6 +104,7 @@ def test_default_factor_arguments() -> None: assert factor_args.strategy == "ekfac" assert factor_args.use_empirical_fisher is False assert factor_args.amp_dtype is None + assert factor_args.amp_scale == 2.0**16 assert factor_args.has_shared_parameters is False assert factor_args.covariance_max_examples == 100_000