Skip to content

Commit bc56093

Browse files
committed
Fix linting
1 parent 4031fdf commit bc56093

File tree

1 file changed

+1
-11
lines changed

1 file changed

+1
-11
lines changed

kronfluence/analyzer.py

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
from typing import Optional
22

33
from accelerate.utils import extract_model_from_parallel
4-
from factor.config import FactorConfig
54
from safetensors.torch import save_file
65
from torch import nn
76
from torch.utils import data
@@ -11,7 +10,6 @@
1110
from kronfluence.computer.eigen_computer import EigenComputer
1211
from kronfluence.computer.pairwise_score_computer import PairwiseScoreComputer
1312
from kronfluence.computer.self_score_computer import SelfScoreComputer
14-
from kronfluence.module.constants import FACTOR_TYPE
1513
from kronfluence.module.utils import wrap_tracked_modules
1614
from kronfluence.task import Task
1715
from kronfluence.utils.dataset import DataLoaderKwargs
@@ -121,7 +119,7 @@ def fit_all_factors(
121119
dataloader_kwargs: Optional[DataLoaderKwargs] = None,
122120
factor_args: Optional[FactorArguments] = None,
123121
overwrite_output_dir: bool = False,
124-
) -> Optional[FACTOR_TYPE]:
122+
) -> None:
125123
"""Computes all necessary factors for the given factor strategy. As an example, EK-FAC
126124
requires (1) computing covariance matrices, (2) performing Eigendecomposition, and
127125
(3) computing Lambda (corrected-eigenvalues) matrices.
@@ -163,11 +161,3 @@ def fit_all_factors(
163161
factor_args=factor_args,
164162
overwrite_output_dir=overwrite_output_dir,
165163
)
166-
167-
if factor_args is None:
168-
factor_args = FactorArguments()
169-
strategy = factor_args.strategy
170-
factor_config = FactorConfig.CONFIGS[strategy]
171-
return self._load_all_required_factors(
172-
factors_name=factors_name, strategy=strategy, factor_config=factor_config
173-
)

0 commit comments

Comments
 (0)