Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add constrained types RFC #213

Merged
merged 10 commits into from
Feb 6, 2024
Merged

Add constrained types RFC #213

merged 10 commits into from
Feb 6, 2024

Conversation

SeanTAllen
Copy link
Member

No description provided.

@SeanTAllen SeanTAllen requested a review from a team January 23, 2024 02:17
@ponylang-main ponylang-main added discuss during sync Should be discussed during an upcoming sync status - new The RFC is new and ready for discussion. and removed discuss during sync Should be discussed during an upcoming sync labels Jan 23, 2024
@ponylang-main ponylang-main mentioned this pull request Jan 23, 2024
Closed
rhagenson
rhagenson reviewed Jan 23, 2024
View reviewed changes
Copy link
Member

@rhagenson rhagenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting edits that I saw. There is one incomplete sentence as well.

I like the idea of including this in either stdlib or ponylang organization.

text/0000-constrained-types.md Outdated Show resolved Hide resolved
text/0000-constrained-types.md Outdated Show resolved Hide resolved
text/0000-constrained-types.md Outdated Show resolved Hide resolved
text/0000-constrained-types.md Outdated Show resolved Hide resolved
text/0000-constrained-types.md Outdated Show resolved Hide resolved
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Jan 23, 2024
SeanTAllen and others added 5 commits January 23, 2024 13:41
@SeanTAllen @rhagenson
Update text/0000-constrained-types.md
c339244 
Co-authored-by: Ryan A. Hagenson <Ryan.Hagenson@gmail.com>
@SeanTAllen @rhagenson
Update text/0000-constrained-types.md
f709ce5 
Co-authored-by: Ryan A. Hagenson <Ryan.Hagenson@gmail.com>
@SeanTAllen @rhagenson
Update text/0000-constrained-types.md
111d2f4 
Co-authored-by: Ryan A. Hagenson <Ryan.Hagenson@gmail.com>
@SeanTAllen @rhagenson
Update text/0000-constrained-types.md
3fd966e 
Co-authored-by: Ryan A. Hagenson <Ryan.Hagenson@gmail.com>
@SeanTAllen @rhagenson
Update text/0000-constrained-types.md
df274f0 
Co-authored-by: Ryan A. Hagenson <Ryan.Hagenson@gmail.com>
@SeanTAllen SeanTAllen added status - final comment period The RFC is finalized. Waiting for final comments. and removed status - new The RFC is new and ready for discussion. labels Jan 30, 2024
@jemc jemc added the status - new The RFC is new and ready for discussion. label Jan 30, 2024
@ponylang-main ponylang-main mentioned this pull request Jan 30, 2024
Closed
@SeanTAllen SeanTAllen removed the status - new The RFC is new and ready for discussion. label Jan 30, 2024
@SeanTAllen
Copy link
Member Author

There was a comment from @adrianboyko that was on a commit and doesn't appear in the UI. It was a good comment about the naming of ValidationErrors. @adrianboyko can you repeat the comment for everyone.

At any rate, I made the suggested change.

@adrianboyko
Copy link

My suggestion was this: Since the opposite of "success" is "failure", the counterpart of ValidationSuccess should be ValidationFailure and not ValidationErrors. The errors are an attribute of the failure, accessible through fun errors(). The errors explain the failure but they are not the failure itself.

@SeanTAllen
Copy link
Member Author

Accepted.

@SeanTAllen SeanTAllen merged commit e36c261 into main Feb 6, 2024
2 checks passed
@SeanTAllen SeanTAllen deleted the validation-to-stdlib branch February 6, 2024 19:19
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhagenson rhagenson rhagenson left review comments

@jemc jemc jemc approved these changes

Assignees
No one assigned
Labels
status - final comment period The RFC is finalized. Waiting for final comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SeanTAllen @adrianboyko @jemc @rhagenson @ponylang-main