Multiple calls to the same function

[martriay]

Today etherplex supports batching multiple calls to the same contract and it constructs a return object of the form result[call.caller.__name][call.fd.name] = result. The problem with this is that it writes over previous calls to the same function.

Example code to reproduce the issue:

      const values = await batch(
        provider,
        etherplexDaiContract
          .balanceOf(userAddresses[0])
          .balanceOf(userAddresses[1])
          .balanceOf(userAddresses[2])
      )

Would result in a single element array

{
    "Dai": {
        balanceOf: [ {_hex: "0x00", _ethersType: "BigNumber"} ]
        balanceOf(address): ...
    }
}

[mdatsev]

Here is a workaround function:

const { contract, encodeData, prepareTransaction } = require('@pooltogether/etherplex');
async function batchArrayResult(provider, ...batchCalls) {
  const [, calls, data] = encodeData(...batchCalls);
  const { chainId } = await provider.getNetwork();
  const callResponse = await provider.send('eth_call', [await prepareTransaction(chainId, data), "latest"]);
  const [, returnValues] = ethers.utils.defaultAbiCoder.decode(['uint256', 'bytes[]'], callResponse);
  const results = [];
  for (let i = 0; i < returnValues.length; i++) {
    let call = calls[i]
    let decoded = call.caller.__interface.decodeFunctionResult(call.fd, returnValues[i])
    results.push(decoded);
  }
  return results;
}

using it instead of batch in your example results in:

[
  [ BigNumber { _hex: '0x00', _isBigNumber: true } ],
  [ BigNumber { _hex: '0x06acad3426894c2afc', _isBigNumber: true } ],
  [ BigNumber { _hex: '0x056bc75e2e327df451', _isBigNumber: true } ]
]