Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date format isn't consistent #64

Open
Xodarap opened this issue Oct 29, 2013 · 0 comments
Open

Date format isn't consistent #64

Xodarap opened this issue Oct 29, 2013 · 0 comments

Comments

@Xodarap
Copy link

Xodarap commented Oct 29, 2013

When saving dates in the provider-patient association code, we call start_date = Time.parse(dates[:start_date]).to_i. This assumes d/m/y format. Displaying dates in that page calls Time.at(perf.start_date).strftime("%m/%d/%y") which is m/d/y. This means that loading the page, making no changes, and saving will result in the dates being changed.

These should either both be m/d/y or d/m/y, depending on who the target audience of popHealth is.

Also client side validation would be good - if I enter 10/31/13 expecting the dates to be in m/d/y format I get the error page because Time.at fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant