Skip to content

Commit c7c252c

Browse files
authored
[Core] Changed logs to not have info by default (#982)
# Description What - Changed logs for "Request for x" to be leveled by if its docs or not Why - Have verbosity when needed How - Added if and logged by condition ## Type of change Please leave one option from the following and delete the rest: - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] New Integration (non-breaking change which adds a new integration) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [x] Non-breaking change (fix of existing functionality that will not change current behavior) - [ ] Documentation (added/updated documentation) <h4> All tests should be run against the port production environment(using a testing org). </h4> ### Core testing checklist - [ ] Integration able to create all default resources from scratch - [ ] Resync finishes successfully - [ ] Resync able to create entities - [ ] Resync able to update entities - [ ] Resync able to detect and delete entities - [ ] Scheduled resync able to abort existing resync and start a new one - [ ] Tested with at least 2 integrations from scratch - [ ] Tested with Kafka and Polling event listeners - [ ] Tested deletion of entities that don't pass the selector ### Integration testing checklist - [ ] Integration able to create all default resources from scratch - [ ] Resync able to create entities - [ ] Resync able to update entities - [ ] Resync able to detect and delete entities - [ ] Resync finishes successfully - [ ] If new resource kind is added or updated in the integration, add example raw data, mapping and expected result to the `examples` folder in the integration directory. - [ ] If resource kind is updated, run the integration with the example data and check if the expected result is achieved - [ ] If new resource kind is added or updated, validate that live-events for that resource are working as expected - [ ] Docs PR link [here](#) ### Preflight checklist - [ ] Handled rate limiting - [ ] Handled pagination - [ ] Implemented the code in async - [ ] Support Multi account ## Screenshots Include screenshots from your environment showing how the resources of the integration will look. ## API Documentation Provide links to the API documentation used for this integration.
1 parent 86c0ccd commit c7c252c

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

port_ocean/middlewares.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,14 @@ async def request_handler(
5252
request_id = generate_uuid()
5353

5454
with logger.contextualize(request_id=request_id):
55-
logger.bind(url=str(request.url), method=request.method).info("Request started")
55+
log_level = (
56+
"DEBUG"
57+
if request.url.path == "/docs" or request.url.path == "/openapi.json"
58+
else "INFO"
59+
)
60+
logger.bind(url=str(request.url), method=request.method).log(
61+
log_level, f"Request to {request.url.path} started"
62+
)
5663
response = await _handle_silently(call_next, request)
5764

5865
end_time = get_time(seconds_precision=False)
@@ -61,5 +68,6 @@ async def request_handler(
6168
response.headers["X-Process-Time"] = str(time_elapsed)
6269
logger.bind(
6370
time_elapsed=time_elapsed, response_status=response.status_code
64-
).info("Request ended")
71+
).log(log_level, f"Request to {request.url.path} ended")
72+
6573
return response

0 commit comments

Comments
 (0)