Skip to content

Commit 39536c2

Browse files
authored
Fix R restart test with new Kallichore build (#5387)
Addresses #5356; fixes restarts on R and re-enables the R console tests. The bug was upstream, in the supervisor; the issue was that during a restart, the channel that broadcast status updates to the client would blink offline. If the 'starting' status got sent during that blink, the client would miss it and not detect startup correctly. The fix is to ensure the channel always broadcasts updates throughout the restart cycle. ### QA Notes As noted by @jonvanausdeln, this is 100% reproducible on Windows, so it should be easy to test the fix there.
1 parent 34695a1 commit 39536c2

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

extensions/positron-supervisor/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@
9797
},
9898
"positron": {
9999
"binaryDependencies": {
100-
"kallichore": "0.1.18"
100+
"kallichore": "0.1.19"
101101
}
102102
},
103103
"dependencies": {

test/smoke/src/areas/positron/console/r-console.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@ import { expect } from '@playwright/test';
77
import { Application, PositronRFixtures } from '../../../../../automation';
88
import { setupAndStartApp } from '../../../test-runner/test-hooks';
99

10-
// Skipping due to https://github.com/posit-dev/positron/issues/5356
11-
describe.skip('Console Pane: R', () => {
10+
describe('Console Pane: R', () => {
1211
setupAndStartApp();
1312

1413
describe('R Console Restart #web #win', () => {

0 commit comments

Comments
 (0)