feat(r): tbl() output from querychat_server() to enable query chaining
#53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...instead of requiring explicit DataSource subclass creation
…provements Plus some improvements: - Cleaner .md file reading code in example apps - Use GPT-4.1 by default, not GPT-4 😬 - Make sqlalchemy required
…-datasource-improvements
fix: No longer need to manually calls session$ns() with shinychat (#1…
R generic datasource
update to use s3 classes to simplify the code
Previously, the examples/app-database.R would shown an error on startup because the initial query was "", which was then sent as a SQL query to RSQLite. The get_lazy_data code path accounted for the "" query, so we decided to make the eager code path just call the lazy code path, then collect(). Also fixed a formatting issue with the table.
It seems like dbplyr tables-as-queries can be a bit... temperamental. This should fix that by explicitly declaring sql always.
Contributor
Author
|
ping @gadenbuie |
Contributor
|
Hi @npelikan, thanks for this contribution. I'd be happy to take a look, but before I do, would you mind resolving the git conflicts and also try to reduce the size of the diff? Specifically, there is a rather large diff to |
Contributor
|
On 2nd thought, it might be better for us to take this PR as inspiration and do something a bit more from scratch. We may still ask some questions based on the work here though if you don't mind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #51
Per our discussion on #28 , this implements dbplyr
tbl()output support to allow query chaining. Added some defensive programming to mitigate LLM-introduced SQL syntax errors. Also, I bulked up the examples