Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library should surface errors, not suppress them #11

Open
daveauerbach opened this issue Feb 11, 2016 · 0 comments
Open

Library should surface errors, not suppress them #11

daveauerbach opened this issue Feb 11, 2016 · 0 comments

Comments

@daveauerbach
Copy link
Contributor

This code is both library code and code to run a process on a server. Mixing these means that it is hard to meet both demands. Case in point: #10

That change introduced a dependency on Sentry, for one thing. It also suppresses bad data in favor of logging that bad data to sentry.

A much better pattern would be that each record is returned with an error state that allows the calling code to deal with it as it wished. However, that pattern doesn't work too well with the need to checkpoint and batch load data as the design currently stands. We should clean this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant