Merge pull request #12 from ShoshBeer/fix_max_cache_issue

Fix error when sending more than 15 requests

Author: ppizarror

PyMultiDictionary/_dictionary.py

@@ -143,7 +143,7 @@ def _bsoup(self, link: str, encoding: str = 'utf-8') -> Optional['BeautifulSoup'
         _CACHED_SOUPS[link] = bs
         if len(bs_keys) >= self._max_cached_websites:
             # noinspection PyTypeChecker
-            del _CACHED_SOUPS[bs[0]]
+            del _CACHED_SOUPS[bs_keys[0]]
         return bs
 
     def _save_bsoup(self, link: str, filename: str, encoding: str = 'utf-8') -> None:

test/test_dictionary.py

@@ -268,6 +268,21 @@ def test_antonym(self) -> None:
         # Test invalid dictionary
         # self.assertRaises(InvalidDictionary, lambda: d.antonym('es', 'word', dictionary=DICT_SYNONYMCOM))
 
+    def test_overwrite_cache(self) -> None:
+        """
+        Test request with maxed out cache.
+        """
+        d = self._get_dictionary('words', 'are', 'super', 'fun')
+        d.set_words_lang('en')
+        d._max_cached_websites = 3
+
+        self.assertEqual(len(d.get_synonyms()), 4)
+        self.assertEqual(len(d.get_synonyms(dictionary=DICT_EDUCALINGO)), 4)
+        self.assertEqual(len(d.get_synonyms(dictionary=DICT_SYNONYMCOM)), 4)
+        self.assertEqual(len(d.get_synonyms(dictionary=DICT_THESAURUS)), 4)
+        self.assertEqual(len(d.get_meanings(dictionary=DICT_WORDNET)), 4)
+
+
     def test_language_name(self) -> None:
         """
         Test language name.