Add support for image embeds in chat overlay

[darkralts]

Describe the new feature:
when you send an osu screenshot (eg https://osu.ppy.sh/ss/6000000) to a friend or maybe even in a chat, have an option for embedding it
Proposal designs of the feature:

[LittleEndu]

Disagree with embedding it, that just isn't what the chat is for. If anything it could load a preview when hovering over the link.

[enoslayd]

What if when screen shot link was clicked there will be an inclient viewer?

[sr229]

I honestly disagree making this an option since osu is not a social application, the social features are there to allow you to communicate via text chat, but if you really just want to share things there, use Discord or something else for that.

[autoteelar]

I honestly disagree making this an option since osu is not a social application, the social features are there to allow you to communicate via text chat, but if you really just want to share things there, use Discord or something else for that.

it kind of is though

[frenzibyte]

I see no problem with having an in-client image viewer, along with markdown rendering. It would be bad UX if you can't click on the image to fill the screen and look at it in-depth.

[darkralts]

ah that would be cool,
i think i like that idea better actually :D

[Game4all]

I think that before worrying about how screenshots links should be rendered in the client, we should probably assessing first whether we want to port to lazer the ability to upload screenshots present on stable.

[autoteelar]

it will be added, peppy said he wants to make lazer so good there is 0 reason to use the old client, and that would include that feature, if not it wouldnt match the 0 reason quota.

[Game4all]

I have opened an issue to track this addition (#10718 for reference).

[enoslayd]

Thats given

[LittleEndu]

In-client image viewer with preview on hover that supports all images from known safe hosting sites would be the way to go. Again, I disagree with embedding it (unless it was made an option, but that probably won't happen) and would like it if the thread title was changed to better reflect what people have suggested here.

[gagahpangeran]

How about markdown support for image in chat?

[darkralts]

I kind of meant for osu.ppy.sh screenshots, I think embeds would be pretty clean, and if it's just osu screenshots it would be safe, it's peppys server after all! :) hovering sounds like the way to go for everything else though

…

On Thu, May 27, 2021 at 11:25 AM Endrik ***@***.***> wrote: In-client image viewer with preview on hover that supports all images from known safe hosting sites would be the way to go. Again, I disagree with embedding it (unless it was made an option, but that probably won't happen) and would like it if the thread title was changed to better reflect what people have suggested here. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#13168 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD43UG7D2IWFUJODMXJLIM3TPZQABANCNFSM45URWZCQ> .

[developomp]

Since the image might be hosted in a malicious website (for IP gathering or smth), this feature should be limit only to osu.ppy.sh domain.

[gagahpangeran]

I think the general direction of this idea is support for markdown in chat (#9145).

With this feature, you can embed image from any image hosting with markdown syntax.