Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friends' online status doesn't update ever #13604

Open
frenzibyte opened this issue Jun 21, 2021 · 8 comments · May be fixed by #31444
Open

Friends' online status doesn't update ever #13604

frenzibyte opened this issue Jun 21, 2021 · 8 comments · May be fixed by #31444
Labels
area:overlay-dashboard priority:1 Very important. Feels bad without fix. Affects the majority of users. type:online

Comments

@frenzibyte
Copy link
Member

frenzibyte commented Jun 21, 2021

Split from #13493.

Might want to be polled at APIAccess every 5000ms or similar, with a RefetchFriends method invoked upon opening the friends section of dashboard overlay.

@frenzibyte frenzibyte added type:behavioural priority:2 Moderately important. Relied on by some users or impeding the usability of the game labels Jun 21, 2021
@peppy
Copy link
Member

peppy commented Jun 22, 2021

What's the intended purpose here? To update online statuses or something else?

@frenzibyte
Copy link
Member Author

Updating APIAcccess.Friends list to match current state, mainly for the dashboard friends display to stay updated.

@peppy
Copy link
Member

peppy commented Jun 22, 2021

As in if a user adds a friend from the website or something like that? We probably want to wait for a push based event flow to come online before considering this. I don't think it's important enough to be polling, let alone every 5 seconds. Maybe once every hour, or if decided better, when the overlay is opened.

@minasminas
Copy link

minasminas commented Jun 22, 2021

As the original issue was opened by me, I would guess the intention here is to update the Online status of the friends list, as they don't update at the moment.

@minasminas

This comment has been minimized.

@peppy

This comment has been minimized.

@LePenner

This comment was marked as spam.

@peppy peppy changed the title APIAccess.Friends does not get updated for the whole session Friends' online status doesn't update ever Jan 2, 2025
@peppy peppy added priority:1 Very important. Feels bad without fix. Affects the majority of users. and removed priority:2 Moderately important. Relied on by some users or impeding the usability of the game labels Jan 2, 2025
@peppy
Copy link
Member

peppy commented Jan 2, 2025

This needs super high priority. It's a core foundation of osu! that you know when your friends are online.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:overlay-dashboard priority:1 Very important. Feels bad without fix. Affects the majority of users. type:online
Projects
None yet
6 participants