Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add combo colour override control to editor #25608

Open
peppy opened this issue Nov 30, 2023 Discussed in #25572 · 0 comments · May be fixed by #31473
Open

Add combo colour override control to editor #25608

peppy opened this issue Nov 30, 2023 Discussed in #25572 · 0 comments · May be fixed by #31473
Assignees
@bdach
Labels
area:editor

Comments

@peppy
Copy link
Member

peppy commented Nov 30, 2023

Discussed in #25572

Originally posted by lunauii November 25, 2023
This is a parity feature request from stable to lazer.

Stable currently allows you to manually set the combo color of a combo in a beatmap by expanding the New Combo arrow after selecting the first note in a combo:
image

In lazer, this currently does not exist or is not in an intuitive position:
image

This is currently preventing lazer mappers from adding really creative thematic combo sections and instead makes us rely on implementing an excess amount of colors in a map to force a combo color in a specific section.

I'd like there to be a menu toggle when right clicking a combo starter:
image

or perhaps even a new option in the inspector for combo starters:
image

It would really help if this would be implemented and would make the laser editor even closer to stable! 🙏
@bdach bdach self-assigned this Jan 9, 2025
bdach added a commit to bdach/osu that referenced this issue Jan 10, 2025
@bdach
Add combo colour override control to editor
cc9511a 
Closes ppy#25608.

Logic mostly matching stable. All operations are done on `ComboOffset`
which still makes overridden combo colours weirdly relatively dependent
on each other rather than them be an "absolute" choice, but alas...

As per stable, two consecutive new combos can use the same colour only
if they are separated by a break:

    https://github.com/peppy/osu-stable-reference/blob/52f3f75ed7efd7b9eb56e1e45c95bb91504337be/osu!/GameModes/Edit/Modes/EditorModeCompose.cs#L4564-L4571

This control is only available once the user has changed the combo
colours from defaults; additionally, only a single new combo object
must be selected for the colour selector to show up.
bdach added a commit to bdach/osu that referenced this issue Jan 10, 2025
@bdach
Add combo colour override control to editor
4819694 
Closes ppy#25608.

Logic mostly matching stable. All operations are done on `ComboOffset`
which still makes overridden combo colours weirdly relatively dependent
on each other rather than them be an "absolute" choice, but alas...

As per stable, two consecutive new combos can use the same colour only
if they are separated by a break:

    https://github.com/peppy/osu-stable-reference/blob/52f3f75ed7efd7b9eb56e1e45c95bb91504337be/osu!/GameModes/Edit/Modes/EditorModeCompose.cs#L4564-L4571

This control is only available once the user has changed the combo
colours from defaults; additionally, only a single new combo object
must be selected for the colour selector to show up.
@bdach bdach linked a pull request Jan 10, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdach bdach

Labels
area:editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add combo colour override control to editor bdach/osu
2 participants
@peppy @bdach