Fix pen input not being friendly with touch #6509
Conversation
frenzibyte
force-pushed
the
square-one
branch
from
aa95565 to
1312fb7
Compare
|
was sort of hoping this would also fix my use case of surface pro pen + touch input on windows (screen capture), but that has never worked unlike the ios pen ideally i think mouse aim + touch tapping should be supported as well but we'll see |
|
Are you testing with SDL3? |
|
hmm, same results. made a discussion #6510 and put the logs there |
|
You may need to wait for the next SDL3-CS release since SDL3 added Windows Ink support after our last update. I also tried it on Android, but I think Pen+Touch playstyle never worked on Android (at least on my device, Galaxy Tab S7 FE) due to how palm rejection is implemented. My device just rejects all touch inputs while the pen is near the screen. On osu!, this PR enables Touch device mod while pen is down, and disables it while pen is hovering. I think it may need a fix. |
There was a problem hiding this comment.
I don't like this change, but it seems this is the simplest fix to make osu! work, so it can go in as a hack. I would like to see the following:
- Add a
FrameworkSettingflag that games (osu!) can set a default - Place the pen handling introduced in this PR behind the flag
- Restore
masterbehaviour when the flag is disabled - Add pen-as-mouse-and-touch tests to
TestSceneOsuTouchInput- It should be easy to modify the tests so they check actual pen input (i.e. make a helper function that calls
InputManager.BeginTouch(), so that it can be substituted forInputManager.PressPen()when someone starts to implement proper pen input)
- It should be easy to modify the tests so they check actual pen input (i.e. make a helper function that calls
I don't know about any of this. Why are we bringing back something that must be working perfectly fine with this PR, it's just introducing a flag that I can't imagine anyone will be bothered enough to use it? If anything, I can move the application of touch input within
I have something like that prepared already, I'll PR it out. |
Fixes pen & touch osu! playstyle on mobile tablets no longer working in the past release.
Back before SDL was bumped, SDL was propagating pen input on iOS in two forms:
This was working perfectly fine with our implementation of
OsuTouchInputMapperin osu! for an elegant pen + touch playstyle. But since we bumped SDL and it became handling pen input natively on iOS and now became directly mapped to mouse input by our implementation inSDL3Window/ #6488, everything fell apart.I initially began on this by looking into updating the implementation of
OsuTouchInputMapperto expect pen input by mouse events, but bailed out after finding multiple catastrophic input-level issues by the idea of sending pen input as mouse input (see #6508 / https://discord.com/channels/188630481301012481/589331078574112768/1332383057642000426).I then attempted to dive right into the o!f input subsystem and try to get things in a right place, then I realised I'm essentially about to propose a top-down refactor of major input components, and I'm absolutely in no place, time, or even interest in doing any of that (nor do I think that anyone will be supporting this effort right at this very moment).
Finally, I decided to just remind myself of how osu! has always been working until now and mimicked that behaviour for now, calling it a day and allowing ourselves to focus on much better and prioritised tasks. In fact, I think the behaviour in this PR might even make more sense with regards to the idea that we want pen and touch input to work harmoniously.
I have tested this on my iPad and it's working perfectly fine everywhere.