Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview doesn't work if the JPEG image doesn't have an EOI marker #43

Open
varunnayak opened this issue Nov 18, 2020 · 7 comments
Open

Comments

@varunnayak
Copy link

varunnayak commented Nov 18, 2020

If you try to upload an image which doesn't have an EOI marker blank preview is shown. This also effects the transform plugin when exif orientation correction is involved. I have tested on the Live Demo on Code Sandbox on Chrome (Version 86.0.4240.198) MacOS Catlina and Android 10
sample

@rikschennink
Copy link
Collaborator

I've never ran into this issue. FilePond can render PNGs and bitmaps as well, and loads JPEGS without exif info. Please create a public test case and supply more information (browser version and os version you tested on). Will close until more details provided.

@varunnayak varunnayak changed the title Preview doesn't work if the image doesn't have an embedded thumbnail Preview doesn't work if the JPEG image doesn't have an EOI marker Nov 19, 2020
@varunnayak
Copy link
Author

varunnayak commented Nov 19, 2020

I've never ran into this issue. FilePond can render PNGs and bitmaps as well, and loads JPEGS without exif info. Please create a public test case and supply more information (browser version and os version you tested on). Will close until more details provided.

Do you need any more information?

@rikschennink
Copy link
Collaborator

@varunnayak the link doesn't point to codesandbox

@varunnayak
Copy link
Author

@varunnayak the link doesn't point to codesandbox

Have updated it. Its the same demo from react-filepond

@rikschennink
Copy link
Collaborator

Ah I see. Okay, will look into it.

@varunnayak
Copy link
Author

@rikschennink Thanks. This issue is common with Panoramas captured using Samsung phones

@rikschennink
Copy link
Collaborator

Finally had some more time to look into this, the problem doesn't appear on Firefox and Safari, it seems to be a Chrome/Blink issue. With a normal image tag Chrome also doesn't always render the image. I'm removing the "bug" label as it seems this is a Chrome issue.

@rikschennink rikschennink removed the bug label Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants