Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running on [push] #8

Open
developit opened this issue Feb 19, 2020 · 4 comments
Open

Support running on [push] #8

developit opened this issue Feb 19, 2020 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@developit
Copy link
Member

As requested on Twitter and in #6, it would be nice to allow running this action on push, in addition to the pull_request workflow. The action should comment on the push with size deltas from its parent commit.

@developit developit added enhancement New feature or request help wanted Extra attention is needed labels Feb 19, 2020
@developit developit added this to the 2.0 milestone Feb 19, 2020
@developit
Copy link
Member Author

This may be fixable via #18, since Checks are supported for individual commits. Still need to figure out what a logical base would be for size comparison.

@developit
Copy link
Member Author

developit commented Jul 9, 2020

I figured out a GraphQL query that can potentially be used to run on push but get the associated PR for a given push (payload properties):

{
  repository(name: "mitt", owner: "jaylinski") {
    object(expression: "e5c9e1505b83fe6e35d54aa5db62aa055921bea5") {
      ...on Commit {
        prs: associatedPullRequests(first: 1, orderBy:{field:UPDATED_AT,direction:DESC}) {
          nodes {
            number,
            resourcePath,
            isCrossRepository,
            baseRefName,
            mergeCommit: potentialMergeCommit { oid }
          }
        }
      }
    }
  }
}

@developit
Copy link
Member Author

developit commented Dec 18, 2020

Potentially can be fixed by #35.

@andrewiggins
Copy link
Member

I updated #35 and marked it ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants