-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video ad units: support different size players on the same ad unit #12245
Comments
You can use twin ad units (repeat the same ad unit definition for each size).
Prebid video mirrors the ORTB protocol (used by a good number of exchanges), where only one size can be provided.
I like this suggestion. |
IT isn't clear that the first one is the best size, it seems throwing an error and forcing the publisher to choose has value. Pinging @fowler446 for his committee input |
We'll talk about it at the next video task force meeting. But, I don't think supporting multiple sizes make sense. The further we deviate from ORTB spec, the more confusing Prebid becomes as a whole. @NathanDigiteka can you elaborate on your particular use case? What are you trying to achieve? You can certainly have a dynamic playerSize that changes based on the state of your video player. Many SSPs will complain if you make an ad request for a different size then the actual size of your player. I find it works best to calculate the playerSize dynamically so that it sends the correct values for the size of your player at the moment of the bid request. |
linking #6138 as relevant. in the past, @mike-chowla flagged why the wrong size was so popular, to meet the gam requirement |
Type of issue
question
Description
Hello everyone,
I have several questions, I implement a video player and I use Prebid. I'd like to be able to send 2 different sizes for my ad requests, is that possible? What does this entail? From the documentation, I can see that this isn't possible.
Why can't we send 2 different sizes? Why do we only need one?
And why, if the size doesn't have the right format, do you delete the entire playerSize element from the array and not just keep the first element (the first size)?
In the code where the log :
logError('Detected incorrect configuration of mediaTypes.video.playerSize. Please specify only one set of dimensions in a format like: [[640, 480]]. Removing invalid mediaTypes.video.playerSize property from request.');
delete validatedAdUnit.mediaTypes.video.playerSize;
Thank you
The text was updated successfully, but these errors were encountered: