Skip to content

Commit 4264801

Browse files
authored
fix argument handling and trimming of GITHUB_REF (#51)
1 parent d1ee3dd commit 4264801

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

.github/workflows/publish.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,9 @@ jobs:
9393
- name: Semantic Release
9494
id: semantic # Need an `id` for output variables
9595
uses: cycjimmy/semantic-release-action@v2
96-
extra_plugins: |
97-
@jedmao/semantic-release-npm-github-config
96+
with:
97+
extra_plugins: |
98+
@jedmao/semantic-release-npm-github-config
9899
env:
99100
GH_TOKEN: ${{ secrets.GH_TOKEN }}
100101
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
[![Build Status][build-status-image]][build-status-url]
77
[![Dependency Status][daviddm-image]][daviddm-url]
88
[![Code Coverage][coverage-image]][coverage-url]
9-
109
[![License][license-image]][license-url]
1110
[![semantic-release][semantic-release-icon]][semantic-release-url]
1211
[![Code Style][code-style-image]][code-style-url]

src/utils/ci.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ function branchNameForGithubAction() {
1616
}
1717
// GITHUB_REF for commits (i.e. refs/heads/master)
1818
if (GITHUB_REF) {
19-
return GITHUB_REF.split('/')[2]
19+
// replace is used in-case the value is passed and does not contain refs/heads/
20+
return GITHUB_REF.replace('refs/heads/', '')
2021
}
2122
}
2223

@@ -67,7 +68,7 @@ export function getProjectName(opts) {
6768
return get(
6869
firebaserc,
6970
`projects.${projectKey}`,
70-
get(firebaserc, 'projects.master')
71+
get(firebaserc, 'projects.master', get(firebaserc, 'projects.default'))
7172
)
7273
}
7374

0 commit comments

Comments
 (0)