Skip to content
This repository has been archived by the owner on Aug 27, 2019. It is now read-only.

Add "linting" for product JSON (via a CI service?) #103

Open
ajb opened this issue Mar 18, 2016 · 3 comments
Open

Add "linting" for product JSON (via a CI service?) #103

ajb opened this issue Mar 18, 2016 · 3 comments

Comments

@ajb
Copy link
Contributor

ajb commented Mar 18, 2016

This could prevent users from submitting invalid JSON, and would help folks like me out when we accidentally commit dummy data: https://github.com/presidential-innovation-fellows/apps-gov/pull/70/files#diff-1c11e57b0cf0297146cb0555a30d0e0dR8

@stroupaloop
Copy link
Contributor

Do you have a CI you recommend? We've explored a few, but haven't picked one. Keep in mind, this may get pushed down the product feature priority list only because we'll eventually be migrating to rails over the next couple of months.

@ajb
Copy link
Contributor Author

ajb commented Mar 22, 2016

So there are actually two components: a test script/runner and a CI service.

If you're going to be migrating to Rails, it makes sense to use whichever Ruby test runner (RSpec or minitest) that you prefer.

As for a CI service, I'm a huge fan of CircleCI. Can't recommend them enough. Travis works too, but in my experience it's a bit clunkier.

@stroupaloop
Copy link
Contributor

Solid, will revisit this and add it into the feature release cycle as we spin up v2.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants