Skip to content

Commit d3b91b6

Browse files
authored
Fix url validation regex (#193)
Fix a bug where toplevel domains containing a "-" would falsely be flagged as invalid
1 parent b1d31f8 commit d3b91b6

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

config/issuetracker.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,11 @@ var validIssueTrackers = []IssueTracker{
4040
}
4141

4242
var originPatterns = map[IssueTracker]*regexp.Regexp{
43-
IssueTrackerJira: regexp.MustCompile(`^(https?://)?[a-zA-Z0-9\-]+(\.[a-zA-Z0-9]+)+(:[0-9]+)?$`),
43+
IssueTrackerJira: regexp.MustCompile(`^(https?://)?[a-zA-Z0-9\-]+(\.[a-zA-Z0-9\-]+)+(:[0-9]+)?$`),
4444
IssueTrackerGithub: regexp.MustCompile(`^(https?://)?(www\.)?github\.com/[\w-]+/[\w-]+`),
45-
IssueTrackerGitlab: regexp.MustCompile(`^(https?://)?[a-zA-Z0-9\-]+(\.[a-zA-Z0-9]+)+(:[0-9]+)?/[\w-]+/[\w-]+$`),
45+
IssueTrackerGitlab: regexp.MustCompile(`^(https?://)?[a-zA-Z0-9\-]+(\.[a-zA-Z0-9\-]+)+(:[0-9]+)?/[\w-]+/[\w-]+$`),
4646
IssueTrackerPivotal: regexp.MustCompile(`^(https?://)?(www\.)?pivotaltracker\.com/n/projects/[0-9]+`),
47-
IssueTrackerRedmine: regexp.MustCompile(`^(https?://)?[a-zA-Z0-9\-]+(\.[a-zA-Z0-9]+)+(:[0-9]+)?$`),
47+
IssueTrackerRedmine: regexp.MustCompile(`^(https?://)?[a-zA-Z0-9\-]+(\.[a-zA-Z0-9\-]+)+(:[0-9]+)?$`),
4848
IssueTrackerYoutrack: regexp.MustCompile(`^(https?://)?(www\.)?[0-9A-z-]{2,}\/?.*$`),
4949
IssueTrackerAzure: regexp.MustCompile(`^(https?://)?(www\.)?dev\.azure\.com/([a-zA-Z0-9]+)+\/([a-zA-Z0-9]+)+.*$`),
5050
}

0 commit comments

Comments
 (0)