Commit d05707b
committed
fix(native): Fix OS metrics to report cumulative values for AVG type
All 6 OS-related metrics were defined as **AVG** type but reported as
**delta values**, causing incorrect averaging and potential data loss
in Prometheus monitoring.
Changed metrics to report **cumulative values** since process start:
- presto_cpp.os_user_cpu_time_micros
- presto_cpp.os_system_cpu_time_micros
- presto_cpp.os_num_soft_page_faults
- presto_cpp.os_num_hard_page_faults
- presto_cpp.os_num_voluntary_context_switches
- presto_cpp.os_num_forced_context_switches
This ensures:
1. Alignment with other AVG metrics in the system (task counts,
cache sizes, etc.)
2. Proper rate calculations in monitoring systems and no data loss
regardless of scraping intervals1 parent 12cd04c commit d05707b
File tree
2 files changed
+6
-26
lines changed- presto-native-execution/presto_cpp/main
2 files changed
+6
-26
lines changedLines changed: 6 additions & 18 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
441 | 441 | | |
442 | 442 | | |
443 | 443 | | |
444 | | - | |
445 | | - | |
446 | | - | |
| 444 | + | |
447 | 445 | | |
448 | 446 | | |
449 | 447 | | |
450 | 448 | | |
451 | | - | |
452 | | - | |
453 | | - | |
| 449 | + | |
454 | 450 | | |
455 | 451 | | |
456 | | - | |
457 | | - | |
458 | | - | |
| 452 | + | |
459 | 453 | | |
460 | 454 | | |
461 | | - | |
462 | | - | |
463 | | - | |
| 455 | + | |
464 | 456 | | |
465 | 457 | | |
466 | 458 | | |
467 | | - | |
468 | | - | |
469 | | - | |
| 459 | + | |
470 | 460 | | |
471 | 461 | | |
472 | 462 | | |
473 | | - | |
474 | | - | |
475 | | - | |
| 463 | + | |
476 | 464 | | |
477 | 465 | | |
478 | 466 | | |
| |||
Lines changed: 0 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
142 | 142 | | |
143 | 143 | | |
144 | 144 | | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | 145 | | |
154 | 146 | | |
155 | 147 | | |
| |||
0 commit comments