Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document fix about AI item pointer overflowing #1066

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Document fix about AI item pointer overflowing #1066

merged 4 commits into from
Aug 10, 2023

Conversation

Idain
Copy link
Contributor

@Idain Idain commented Aug 10, 2023 •
edited
Loading

Fixes #1065

vulcandth
vulcandth requested changes Aug 10, 2023
View reviewed changes
docs/bugs_and_glitches.md Outdated Show resolved Hide resolved
@Idain @vulcandth
Update docs/bugs_and_glitches.md
6854485 
Co-authored-by: vulcandth <vulcandth@gmail.com>
vulcandth
vulcandth approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@vulcandth vulcandth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Idain verified the bug exists and the bugfix works.

Rangi42
Rangi42 reviewed Aug 10, 2023
View reviewed changes
docs/bugs_and_glitches.md Outdated Show resolved Hide resolved
Rangi42
Rangi42 reviewed Aug 10, 2023
View reviewed changes
engine/battle/ai/items.asm Outdated Show resolved Hide resolved
Rangi42
Rangi42 reviewed Aug 10, 2023
View reviewed changes
docs/bugs_and_glitches.md Outdated Show resolved Hide resolved
Rangi42
Rangi42 reviewed Aug 10, 2023
View reviewed changes
docs/bugs_and_glitches.md Outdated Show resolved Hide resolved
Rangi42
Rangi42 reviewed Aug 10, 2023
View reviewed changes
docs/bugs_and_glitches.md Outdated Show resolved Hide resolved
@Rangi42 Rangi42 merged commit 6926900 into pret:master Aug 10, 2023
1 check passed
vulcandth added a commit to pret/pokegold that referenced this pull request Aug 10, 2023
@vulcandth @Idain
Document fix about AI item pointer overflowing (pret/pokecrystal#1066)
47c19fd 
Co-Authored-By: Idain <54337884+Idain@users.noreply.github.com>
EXGomora added a commit to EXGomora/pokeZ that referenced this pull request Aug 11, 2023
@EXGomora
Merge pull request #9 from pret/master
eff015b 
Document fix about AI item pointer overflowing (pret#1066)
Idain added a commit to Idain/pokecrystal that referenced this pull request Sep 11, 2023
@Idain
Document fix about AI item pointer overflowing (pret#1066)
84d77a1
Idain added a commit to Idain/pokecrystal that referenced this pull request Sep 12, 2023
@Idain
Document fix about AI item pointer overflowing (pret#1066)
a7e31dd
@Idain Idain deleted the AI_TryItem_fix branch December 7, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vulcandth vulcandth vulcandth approved these changes

@Rangi42 Rangi42 Rangi42 approved these changes

Assignees
No one assigned
Labels
bug docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: After a trainer uses its 1st item, it'll start reading past the item list for items to use
3 participants
@Idain @vulcandth @Rangi42