Remove shared SimpleDateFormat instances in date adapters

Since SimpleDateFormat is not thread safe, we might be running into race
conditions here actually.
Re-creating a new instance is expensive, so this is only a temporary
fix while we validate a change to DateTimeFormatter.

Author: antweb

libpretixsync/src/main/java/eu/pretix/libpretixsync/sqldelight/AndroidUtilDateAdapter.kt

@@ -6,19 +6,21 @@ import java.util.Date
 import java.util.TimeZone
 
 class AndroidUtilDateAdapter : ColumnAdapter<Date, String> {
-    private val df = SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss'Z'").apply {
-        timeZone = TimeZone.getTimeZone("UTC")
-    }
-
     override fun decode(databaseValue: String): Date {
         try {
+            val df = SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss'Z'").apply {
+                timeZone = TimeZone.getTimeZone("UTC")
+            }
             return df.parse(databaseValue)
         } catch (e: Throwable) {
             throw e
         }
     }
 
     override fun encode(value: Date): String {
+        val df = SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss'Z'").apply {
+            timeZone = TimeZone.getTimeZone("UTC")
+        }
         return df.format(value)
     }
 }

libpretixsync/src/main/java/eu/pretix/libpretixsync/sqldelight/JavaUtilDateAdapter.kt

@@ -5,13 +5,14 @@ import java.text.SimpleDateFormat
 import java.util.Date
 
 class JavaUtilDateAdapter : ColumnAdapter<Date, String> {
-    private val df = SimpleDateFormat("yyyy-MM-dd HH:mm:ss.SSS")
 
     override fun decode(databaseValue: String): Date {
+        val df = SimpleDateFormat("yyyy-MM-dd HH:mm:ss.SSS")
         return df.parse(databaseValue)
     }
 
     override fun encode(value: Date): String {
+        val df = SimpleDateFormat("yyyy-MM-dd HH:mm:ss.SSS")
         return df.format(value)
     }
 }