feat: format new without parenthesis in PHP 8.4 (#2422)

* deps: bump php-parser to 3.2.5

* feat: add php 8.4 option

* refactor: move isMinVersion to utils, update needsParen fn signature

needsParens() is already being called with 2 params, but the fn
signature didn't reflect that

* test: prep snapshots for php 8.4 new w/o parens

* feat: support new w/o parens in php 8.4

Author: claytonrcarter

package.json

@@ -27,7 +27,7 @@
   ],
   "dependencies": {
     "linguist-languages": "^8.0.0",
-    "php-parser": "^3.2.4"
+    "php-parser": "^3.2.5"
   },
   "devDependencies": {
     "@babel/preset-env": "^7.27.2",

src/needs-parens.mjs

@@ -1,6 +1,11 @@
-import { getPrecedence, shouldFlatten, isBitwiseOperator } from "./util.mjs";
-
-function needsParens(path) {
+import {
+  getPrecedence,
+  shouldFlatten,
+  isBitwiseOperator,
+  isMinVersion,
+} from "./util.mjs";
+
+function needsParens(path, options) {
   const { parent } = path;
 
   if (!parent) {
@@ -128,13 +133,16 @@ function needsParens(path) {
     }
     case "clone":
     case "new": {
+      const requiresParens =
+        node.kind === "clone" ||
+        (node.kind === "new" && !isMinVersion(options.phpVersion, "8.4"));
       switch (parent.kind) {
         case "propertylookup":
         case "nullsafepropertylookup":
         case "staticlookup":
         case "offsetlookup":
         case "call":
-          return key === "what";
+          return key === "what" && requiresParens;
         default:
           return false;
       }

src/options.mjs

@@ -24,6 +24,7 @@ export default {
       { value: "8.1" },
       { value: "8.2" },
       { value: "8.3" },
+      { value: "8.4" },
     ],
   },
   trailingCommaPHP: {

src/parser.mjs

@@ -1,4 +1,5 @@
 import engine from "php-parser";
+import options from "./options.mjs";
 
 function parse(text, opts) {
   const inMarkdown = opts && opts.parentParser === "markdown";
@@ -10,10 +11,15 @@ function parse(text, opts) {
   // Todo https://github.com/glayzzle/php-parser/issues/170
   text = text.replace(/\?>\n<\?/g, "?>\n___PSEUDO_INLINE_PLACEHOLDER___<?");
 
+  const latestSupportedPhpVersion = Math.max(
+    ...options.phpVersion.choices.map((c) => parseFloat(c.value))
+  );
+
   // initialize a new parser instance
   const parser = new engine({
     parser: {
       extractDoc: true,
+      version: `${latestSupportedPhpVersion}`,
     },
     ast: {
       withPositions: true,

src/printer.mjs

@@ -37,6 +37,7 @@ import {
   isReferenceLikeNode,
   normalizeMagicMethodName,
   isSimpleCallArgument,
+  isMinVersion,
 } from "./util.mjs";
 
 const {
@@ -65,10 +66,6 @@ const {
   isPreviousLineEmpty,
 } = prettierUtil;
 
-function isMinVersion(actualVersion, requiredVersion) {
-  return parseFloat(actualVersion) >= parseFloat(requiredVersion);
-}
-
 function shouldPrintComma(options, requiredVersion) {
   if (!options.trailingCommaPHP) {
     return false;

src/util.mjs

@@ -709,6 +709,10 @@ function memoize(fn) {
   };
 }
 
+function isMinVersion(actualVersion, requiredVersion) {
+  return parseFloat(actualVersion) >= parseFloat(requiredVersion);
+}
+
 export {
   printNumber,
   getPrecedence,
@@ -740,4 +744,5 @@ export {
   normalizeMagicMethodName,
   isSimpleCallArgument,
   memoize,
+  isMinVersion,
 };