Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion between Dialog and DialogV1 #4756

Closed
cihad opened this issue Jul 19, 2024 · 1 comment
Closed

Confusion between Dialog and DialogV1 #4756

cihad opened this issue Jul 19, 2024 · 1 comment
Labels
bug Something isn't working docs Documentation question react

Comments

@cihad
Copy link
Contributor

cihad commented Jul 19, 2024

Description

There are two Dialog component under @primer/react package.

  • Storybook Dialog addresses to import { Dialog } from "@primer/react/lib-esm/Dialog/Dialog"
  • Storybook DialogV1: import { Dialog } from "@primer/react"

Please resolve these confussions.

Steps to reproduce

  1. Go to Storybook Dialog
  2. Go to Storybook DialogV1
  3. Repo exports packages/react/src/Dialog.tsx

Version

36.26.0

Browser

No response

@cihad cihad added the bug Something isn't working label Jul 19, 2024
@joshblack joshblack added docs Documentation question labels Jul 22, 2024
@joshblack
Copy link
Member

Hi there @cihad! Thanks for taking the time to make this issue.

The dialog component available from @primer/react/experimental is the newest version of Dialog and will be the default in the next major version of Primer React. Feel free to use that as opposed to Dialog from @primer/react 👍

Hope this helps! Let me know if you have any other questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Documentation question react
Projects
None yet
Development

No branches or pull requests

2 participants