-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run storybook axe scans on CI builds #5580
Conversation
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
Hi here, @kendallgassner! 👋 Just providing some context, storybook axe scans currently run through playwright (for example) instead of in Jest so that we can get contrast checks reported accurately. We still have some old test suites that use this technique but we can get rid of them (I think 😅) If you're seeing a story not being checked against axe it'd be great to add them to the corresponding e2e test |
👀 Thanks @joshblack! Is there a reason we don't do this for every story? |
@kendallgassner I don't think so, definitely would make sense to run it on every story. It would be worth it to add a dedicated test for this so that each component e2e test doesn't have to add it explicitly which I think is likely the root cause if something is not being checked. |
@joshblack cool! I'll convert this PR to aim to do that |
@@ -72,7 +72,8 @@ const ButtonBase = forwardRef( | |||
if ( | |||
innerRef.current && | |||
!(innerRef.current instanceof HTMLButtonElement) && | |||
!((innerRef.current as unknown) instanceof HTMLAnchorElement) | |||
!((innerRef.current as unknown) instanceof HTMLAnchorElement) && | |||
!((innerRef.current as HTMLElement).tagName === 'SUMMARY') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how I feel about this but the details story feels like it's incorrectly erroring here.
Closing for now while I play around with this locally. |
We noticed in #5559 that our axe-scans do not run on every storybook story. This PR aims to fix that.
Closes #
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist