Skip to content

Commit 29ff6a2

Browse files
committed
Use direct stdout
1 parent 7d25238 commit 29ff6a2

File tree

2 files changed

+31
-40
lines changed

2 files changed

+31
-40
lines changed

.github/workflows/qe-perf.yml

Lines changed: 31 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ on:
33
pull_request:
44
paths-ignore:
55
- ".github/**"
6-
- "!.github/workflows/wasm-perf.yml"
6+
- "!.github/workflows/qe-perf.yml"
77
- ".buildkite/**"
88
- "*.md"
99
- "LICENSE"
@@ -14,58 +14,50 @@ jobs:
1414
run-benchmarks:
1515
name: Run benchmarks
1616
runs-on: ubuntu-latest
17-
outputs:
18-
results: ${{ steps.bench.outputs.results }}
1917
steps:
2018
- name: Checkout PR branch
2119
uses: actions/checkout@v4
2220

23-
- name: "Setup Node.js"
24-
uses: actions/setup-node@v4
25-
with:
26-
node-version: ${{ matrix.node_version }}
21+
# - name: "Setup Node.js"
22+
# uses: actions/setup-node@v4
23+
# with:
24+
# node-version: ${{ matrix.node_version }}
2725

28-
- name: "Setup pnpm"
29-
uses: pnpm/action-setup@v2
30-
with:
31-
version: 8
26+
# - name: "Setup pnpm"
27+
# uses: pnpm/action-setup@v2
28+
# with:
29+
# version: 8
3230

33-
- name: "Get pnpm store directory"
34-
shell: bash
35-
run: |
36-
echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
31+
# - name: "Get pnpm store directory"
32+
# shell: bash
33+
# run: |
34+
# echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
3735

38-
- name: "Login to Docker Hub"
39-
uses: docker/login-action@v3
40-
continue-on-error: true
41-
env:
42-
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
43-
DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
44-
if: "${{ env.DOCKERHUB_USERNAME != '' && env.DOCKERHUB_TOKEN != '' }}"
45-
with:
46-
username: ${{ secrets.DOCKERHUB_USERNAME }}
47-
password: ${{ secrets.DOCKERHUB_TOKEN }}
36+
# - name: "Login to Docker Hub"
37+
# uses: docker/login-action@v3
38+
# continue-on-error: true
39+
# env:
40+
# DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
41+
# DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
42+
# if: "${{ env.DOCKERHUB_USERNAME != '' && env.DOCKERHUB_TOKEN != '' }}"
43+
# with:
44+
# username: ${{ secrets.DOCKERHUB_USERNAME }}
45+
# password: ${{ secrets.DOCKERHUB_TOKEN }}
4846

49-
- uses: dtolnay/rust-toolchain@stable
47+
# - uses: dtolnay/rust-toolchain@stable
5048

51-
- name: Install wasm-pack
52-
run: cargo install wasm-pack
49+
# - name: Install wasm-pack
50+
# run: cargo install wasm-pack
5351

54-
- name: Setup benchmark
55-
run: make setup-pg-bench
52+
# - name: Setup benchmark
53+
# run: make setup-pg-bench
5654

5755
- name: Run benchmarks
5856
id: bench
57+
uses: mathiasvr/command-output@v2.0.0
5958
run: |
60-
echo "results=$(make run-bench)\n" >> $GITHUB_OUTPUT
59+
echo "Foo\nBar"
6160
62-
report:
63-
name: Report benchmarks
64-
runs-on: ubuntu-latest
65-
needs:
66-
- run-benchmarks
67-
68-
steps:
6961
- name: Find past report comment
7062
uses: peter-evans/find-comment@v2
7163
id: findReportComment
@@ -83,6 +75,6 @@ jobs:
8375
### Query engine benchmark results
8476
8577
```sh
86-
${{ needs.run-benchmarks.outputs.results}}
78+
${{ steps.bench.outputs.stdout }}
8779
```
8880
edit-mode: replace

query-engine/driver-adapters/executor/src/bench.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@ async function benchMarkQueries(
9595
}
9696

9797
await run({
98-
colors: true,
9998
collect: true,
10099
});
101100
} finally {

0 commit comments

Comments
 (0)